Skip to content

Conversation

@kiran-kannur
Copy link

@kiran-kannur kiran-kannur commented Oct 25, 2025

/kind feature
/kind test

What this PR does / why we need it:
This PR adds an e2e Bats test suite for the new Fortanix Secret Store CSI Provider integration.

The test covers:

  • Installation of the Fortanix CSI provider using the upstream deployment manifest
  • Validation of SecretProviderClass creation referencing Fortanix DSM
  • Verification that secrets from Fortanix DSM are mounted successfully into a test pod
  • Basic cleanup and teardown steps to ensure the provider, SecretProviderClass, and API key secret are deleted cleanly after test completion

These tests are modeled after existing provider test suites (e.g., AWS, Azure, Vault) and ensure compatibility of the Fortanix provider with the secrets-store-csi-driver e2e test harness.

Which issue(s) this PR fixes:
Fixes #

Is this a chart or deployment yaml update?
No, this PR only adds test files under test/bats/ to include Fortanix provider validation.

Special notes for your reviewer:

  • The Fortanix provider manifest is referenced from its official GitHub repository.
  • Tests require the following environment variables to be set prior to execution:
    • FORTANIX_API_KEY
    • FORTANIX_DSM_ENDPOINT
    • FORTANIX_TEST_SECRET_NAME
  • Verified against Kubernetes v1.30 and secrets-store-csi-driver v1.4.1.

TODOs:

  • Added new Fortanix provider e2e test
  • Verified successful run on kind/minikube
  • Update provider documentation with test instructions
  • (optional) Integrate into CI test matrix once provider image is public

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 25, 2025
@k8s-ci-robot
Copy link
Contributor

@kiran-kannur: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

/kind feature
/kind test

What this PR does / why we need it:
This PR adds an end-to-end Bats test suite for the new Fortanix Secret Store CSI Provider integration.

The test covers:

  • Installation of the Fortanix CSI provider using the upstream deployment manifest
  • Validation of SecretProviderClass creation referencing Fortanix DSM
  • Verification that secrets from Fortanix DSM are mounted successfully into a test pod
  • Basic cleanup and teardown steps to ensure the provider, SecretProviderClass, and API key secret are deleted cleanly after test completion

These tests are modeled after existing provider test suites (e.g., AWS, Azure, Vault) and ensure compatibility of the Fortanix provider with the secrets-store-csi-driver e2e test harness.

Which issue(s) this PR fixes:
Fixes #

Is this a chart or deployment yaml update?
No — this PR only adds test files under test/bats/ to include Fortanix provider validation.

Special notes for your reviewer:

  • The Fortanix provider manifest is referenced from its official GitHub repository.
  • Tests require the following environment variables to be set prior to execution:
  • FORTANIX_API_KEY
  • FORTANIX_DSM_ENDPOINT
  • FORTANIX_TEST_SECRET_NAME
  • The tests are designed to be self-contained and skip gracefully if these environment variables are not defined.
  • Verified against Kubernetes v1.30 and secrets-store-csi-driver v1.4.1.

TODOs:

  • Added new Fortanix provider e2e test
  • Verified successful run on kind/minikube
  • Update provider documentation with test instructions
  • (optional) Integrate into CI test matrix once provider image is public

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 25, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kiran-kannur / name: Kiran Kannur (0ab6ba7)

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 25, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @kiran-kannur!

It looks like this is your first PR to kubernetes-sigs/secrets-store-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/secrets-store-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 25, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @kiran-kannur. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kiran-kannur
Once this PR has been reviewed and has the lgtm label, please assign ritazh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 25, 2025
@enj enj added this to SIG Auth Oct 25, 2025
@enj enj moved this to Subprojects - Needs Triage in SIG Auth Oct 25, 2025
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kiran-kannur Please open a PR in test-infra, similar to kubernetes/test-infra#32573, to add an optional job so these tests can be validated.

Also, please sign the CLA.

@github-project-automation github-project-automation bot moved this from Subprojects - Needs Triage to Changes Requested in SIG Auth Nov 3, 2025
@aramase
Copy link
Member

aramase commented Nov 3, 2025

/retitle test: add e2e for Fortanix CSI provider
/triage accepted

@k8s-ci-robot k8s-ci-robot changed the title Added test for Fortanix secret store CSI provider test: add e2e for Fortanix CSI provider Nov 3, 2025
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 3, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants