Add safe to evict option to capacity buffers injected fake pods #8864
Conversation
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: abdelrahman882 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/M
abdelrahman882
force-pushed
the
buffers-evict-pods
branch
from
61a4b46 to
0cee38c
Compare
abdelrahman882
force-pushed
the
buffers-evict-pods
branch
from
0cee38c to
d5eed0e
Compare
| if pod.Annotations == nil { | ||
| pod.Annotations = make(map[string]string, 1) | ||
| } | ||
| pod.Annotations[drain.PodSafeToEvictKey] = "true" |
There was a problem hiding this comment.
Because we're passing in a static true for this option, this represents a change. We're O.K. that given that this functionality hasn't yet been released?
|
/test pull-cluster-autoscaler-e2e-azure-master |
elmiko
left a comment
elmiko
left a comment
There was a problem hiding this comment.
code generally looks good to me, but i think we should have some unit tests to exercise the true option.
4 participants
What type of PR is this?
/kind feature
What this PR does / why we need it:
Capacity buffer injects fake pods into CA loop, these pods are meant to create some capacity for user workload, this change allows forcing adding safe-to-evict annotation to the pods so these fake pods are drainable and they do not block any logic requires draining them.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?