-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Implement OCI Node force delete functions #8876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @matkam! |
|
Hi @matkam. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: matkam The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind feature
What this PR does / why we need it:
When the
--force-delete-unregistered-nodesargument is enabled, it is unable to delete unresponsive Nodes when the NodePool is at the min number of nodes under cloud providers that do not have theForceDeleteNodesfunction implemented. When this happens in OCI, the autoscaler becomes stuck in an error state:could not extract taints from the nodepool: invalid taint spec: , name part must be non-empty. This PR implementsForceDeleteNodesfunction in order to allow the--force-delete-unregistered-nodesargument to work as intended under OCI.Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?
NONE
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
NONE