Skip to content

Conversation

@nickstern2002
Copy link

What type of PR is this?

What this PR does / why we need it:

Two changes present in this PR

Dropping logic that adds the remove-node label

  • The ToBeDeletedByClusterAutoscaler taint will be used as an indicator that a node should be removed from the node group. The remove-node label will only be managed by an internal controller
  • The Autoscaler's usage of the remove-node label was causing conflicts with the internal controller responsible for reconciling node groups.

Taking the absolute value of delta in the DecreaseTargetSize

  • This is fixing a bug in the current CoreWeave Autoscaler implementation. When DecreaseTargetSize is called delta is passed as a negative value. The CW Autoscaler currently assumes delta is positive. Taking the absolute value of delta resolves this difference

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

This improves the user experience when using the CoreWeave implementation of the Cluster Autoscaler. Specifically prevents scenarios such as too many nodes getting removed and node groups being mistakenly scaled up. 

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-area labels Dec 3, 2025
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 3, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: nickstern2002 / name: Nick Sternheim (6d42554)

@k8s-ci-robot
Copy link
Contributor

Welcome @nickstern2002!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested a review from feiskyer December 3, 2025 17:05
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 3, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @nickstern2002. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested a review from x13n December 3, 2025 17:05
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nickstern2002
Once this PR has been reviewed and has the lgtm label, please assign aleksandra-malinowska for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler area/provider/coreweave size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/needs-area cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cluster-autoscaler area/provider/coreweave cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants