Skip to content

Conversation

@domenicbozzuto
Copy link
Contributor

@domenicbozzuto domenicbozzuto commented Dec 5, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates cloudprovider/aws to use the new aws-sdk-go-v2. Notably, the v2 sdk is not vendored as the v1 sdk was. The individual servcies are now independent modules, vs using a large single monolithic version as the previous SDK did. The original aws-sdk-go package is officially deprecated, and the repo is now archived.

The changes from the v1 SDK are generally as follows:

  • API types and methods are now split into distinct packages
  • Many API types changed to no longer use pointers to data
  • New API to innitiate an API (session.NewSession dropped)
  • Use of aws/smithy-go for configuring API middleware
  • Updates to override endpoint resolution

I can formally remove the old vendored aws-sdk-go package in a subsequent PR, but didn't want to obscure the diff with the removal of 2000+ files.

Which issue(s) this PR fixes:

Fixes # #8671

Special notes for your reviewer:

There is some context in other PRs. I originally planned to vendor the aws-sdk-go-v2 as the v1 sdk was vendored; this work was done in #8265, and planned to consumed the vendored package with #8269.

However:

  • The v2 sdk is significantly larger than v1 sdk
  • Each API service is versioned independently, whereas v1 was monolithically versioned.

From the discussion on that PR, it was suggested it might make more sense to not vendor the package and use it directly; this is similar to how the new azure SDK for go is being handled.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Updates cloudprovider/aws to use the new aws-sdk-go-v2.
Notably, the v2 sdk is not vendored as the v1 sdk was.
The individual servcies are now independent modules, vs
using a large single monolithic version as the previous
SDK did.

The changes from the v1 SDK are generally as follows:
* API types and methods are now split into distinct packages
* Many API types changed to no longer use pointers to data
* New API to innitiate an API (session.NewSession dropped)
* Use of aws/smithy-go for configuring API middleware
* Updates to override endpoint resolution
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/needs-area area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 5, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @domenicbozzuto. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: domenicbozzuto
Once this PR has been reviewed and has the lgtm label, please assign towca for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 5, 2025
@domenicbozzuto
Copy link
Contributor Author

/cc @jackfrancis

Tagging you as you have context on the other PR and discussed this with me in the sig-autoscaling meeting this week 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants