Skip to content

Commit d9ceb91

Browse files
committed
fix api version issue and update api with implementation
1 parent 6c67c31 commit d9ceb91

File tree

1 file changed

+5
-4
lines changed
  • keps/sig-scheduling/4671-gang-scheduling

1 file changed

+5
-4
lines changed

keps/sig-scheduling/4671-gang-scheduling/README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -151,8 +151,9 @@ spec:
151151
completionMode: Indexed
152152
template:
153153
spec:
154-
workload:
154+
workloadRef:
155155
name: job-1
156+
podGroup: pg1
156157
restartPolicy: OnFailure
157158
containers:
158159
- name: ml-worker
@@ -173,7 +174,7 @@ The `Workload` core resource will be introduced. A `Workload` does not create an
173174

174175
It does not affect pod creation by Job or any other controller. A sample resource looks like this:
175176
```yaml
176-
apiVersion: scheduling/v1alpha1
177+
apiVersion: scheduling.k8s.io/v1alpha1
177178
kind: Workload
178179
metadata:
179180
namespace: ns-1
@@ -222,7 +223,7 @@ usecases. You can read more about it in the [extended proposal] document.
222223
### Naming
223224

224225
* `Workload` is the resource Kind.
225-
* `scheduling` is the ApiGroup.
226+
* `scheduling.k8s.io` is the ApiGroup.
226227
* `spec.workload` is the name of the new field in pod.
227228
* Within a Workload there is a list of groups of pods. Each group represents a top-level division of pods within a Workload. Each group can be independently gang scheduled (or not use gang scheduling). This group is named `PodGroup`.
228229
* In a future , we expect that this group can optionally specify further subdivision into sub groups. Each sub-group can have an index. The indexes go from 0 to N, without repeats or gaps. These subgroups are called `PodSubGroup`.
@@ -265,7 +266,7 @@ treat it as a blocker.
265266
The example below shows how this could look like for with the following `Workload` object:
266267

267268
```yaml
268-
apiVersion: scheduling/v1alpha1
269+
apiVersion: scheduling.k8s.io/v1alpha1
269270
kind: Workload
270271
metadata:
271272
name: jobset

0 commit comments

Comments
 (0)