-
Notifications
You must be signed in to change notification settings - Fork 5.1k
discuss: Fix CI build scripts to dynamically detect fork repository names #22020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vtri950 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @vtri950. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Can one of the admins verify this patch? |
|
/cc @nirs |
nirs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vtri950 cool! can you create another minikube fork for testing this change?
You can test the ISO build by editing a file in deploy/iso - for example adding a comment in on of the configuration files. Building iso should work with a fork name minikube or any other name.
Testing may work without additional change, since this change should trigger an ISO build, but I'm not sure the change detection is correct for build scripts.
|
I think you can just use |
633c0ed to
39b7fad
Compare
Do you want me to create this PR from a different fork(from a different account)? |
Yes, we need to test 2 cases:
|
39b7fad to
fc4ea67
Compare
i have changed the name of my existing fork |
|
Testing iso build with custom fork name /ok-to-build-iso |
|
/ok-to-build-iso |
|
Hi @vtri950, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
|
@vtri950 iso was built with custom minikube fork name, lets rename the fork to standard name and test again. You can rename the fork and remove the commit added by the bot. |
|
vtri950 I m curios how are you planning to run the ISO on fork ? where would it push the ISO to ? |
19ecf1d to
fc4ea67
Compare
done |
|
vtri950 currently those commands ok-to-build.... gets answered by jenkins, (not github actions) how would it work on fork ? do you already have an infrastructure that listens to your Fork ? our jenkins is configured to only build images on this repo not forks...so even if you do all these changes it wont be triggered plus the script are configured to push the ISO to a GCS bucket in a GCP project, your fork wont have access to that. so I dont see any usage for this modifcations ever ! |
The iso build fails because of this bug (as mentioned in the issue description) it was detected in #21997
becasue of this i had to change my fork name to the standard (same as standard repo) name as requested by @nirs |
The build_iso.sh and kicbase_auto_build.sh scripts were hardcoding
repository names as "minikube", causing failures when contributors
have differently named forks. This change:
Fixes issues where PRs from forks like "minikube-fork" would fail
during the automated ISO and kicbase build processes.
Fixes #22018