Skip to content

Conversation

@vtri950
Copy link

@vtri950 vtri950 commented Dec 1, 2025

The build_iso.sh and kicbase_auto_build.sh scripts were hardcoding
repository names as "minikube", causing failures when contributors
have differently named forks. This change:

  • Uses GitHub CLI to dynamically fetch the actual fork repository name
  • Adds fallback to "minikube" for backward compatibility
  • Includes SSH/HTTPS protocol fallback for better connectivity
  • Resolves "Repository not found" errors in CI builds

Fixes issues where PRs from forks like "minikube-fork" would fail
during the automated ISO and kicbase build processes.

Fixes #22018

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vtri950
Once this PR has been reviewed and has the lgtm label, please assign comradeprogrammer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 1, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @vtri950. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 1, 2025
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@vtri950
Copy link
Author

vtri950 commented Dec 1, 2025

/cc @nirs

@k8s-ci-robot k8s-ci-robot requested a review from nirs December 1, 2025 16:07
Copy link
Contributor

@nirs nirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vtri950 cool! can you create another minikube fork for testing this change?

You can test the ISO build by editing a file in deploy/iso - for example adding a comment in on of the configuration files. Building iso should work with a fork name minikube or any other name.

Testing may work without additional change, since this change should trigger an ISO build, but I'm not sure the change detection is correct for build scripts.

@afbjorklund
Copy link
Collaborator

afbjorklund commented Dec 1, 2025

I think you can just use refs/pull/123456/head, but there should be GitHub documentation about it

@vtri950 vtri950 force-pushed the remote_as_variable branch from 633c0ed to 39b7fad Compare December 2, 2025 15:33
@vtri950
Copy link
Author

vtri950 commented Dec 2, 2025

@vtri950 cool! can you create another minikube fork for testing this change?

Do you want me to create this PR from a different fork(from a different account)?

@nirs
Copy link
Contributor

nirs commented Dec 2, 2025

@vtri950 cool! can you create another minikube fork for testing this change?

Do you want me to create this PR from a different fork(from a different account)?

Yes, we need to test 2 cases:

  • fork != minikube: we fixed the bug
  • fork == minikube: no regression in common case (forking creates repo with the same name by default)

@vtri950 vtri950 force-pushed the remote_as_variable branch from 39b7fad to fc4ea67 Compare December 3, 2025 16:33
@vtri950
Copy link
Author

vtri950 commented Dec 3, 2025

  • fork != minikube: we fixed the bug

i have changed the name of my existing fork
and pushed a commit (hopefully this will do)

@nirs
Copy link
Contributor

nirs commented Dec 3, 2025

Testing iso build with custom fork name

/ok-to-build-iso

@nirs
Copy link
Contributor

nirs commented Dec 3, 2025

/ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @vtri950, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@nirs
Copy link
Contributor

nirs commented Dec 3, 2025

@vtri950 iso was built with custom minikube fork name, lets rename the fork to standard name and test again. You can rename the fork and remove the commit added by the bot.

@medyagh
Copy link
Member

medyagh commented Dec 5, 2025

vtri950 I m curios how are you planning to run the ISO on fork ? where would it push the ISO to ?
and do you plan to have your own jenkins on the Fork?

@vtri950 vtri950 force-pushed the remote_as_variable branch from 19ecf1d to fc4ea67 Compare December 5, 2025 05:31
@vtri950
Copy link
Author

vtri950 commented Dec 5, 2025

@vtri950 iso was built with custom minikube fork name, lets rename the fork to standard name and test again. You can rename the fork and remove the commit added by the bot.

done

@vtri950
Copy link
Author

vtri950 commented Dec 5, 2025

vtri950 I m curios how are you planning to run the ISO on fork ? where would it push the ISO to ? and do you plan to have your own jenkins on the Fork?

@medyagh sorry but i didn't get your question(s), can you pls provide a little more context?

@medyagh
Copy link
Member

medyagh commented Dec 5, 2025

vtri950 currently those commands ok-to-build.... gets answered by jenkins, (not github actions) how would it work on fork ? do you already have an infrastructure that listens to your Fork ? our jenkins is configured to only build images on this repo not forks...so even if you do all these changes it wont be triggered

plus the script are configured to push the ISO to a GCS bucket in a GCP project, your fork wont have access to that.

so I dont see any usage for this modifcations ever !

@medyagh medyagh changed the title Fix CI build scripts to dynamically detect fork repository names discuss: Fix CI build scripts to dynamically detect fork repository names Dec 5, 2025
@vtri950
Copy link
Author

vtri950 commented Dec 6, 2025

vtri950 currently those commands ok-to-build.... gets answered by jenkins, (not github actions) how would it work on fork ? do you already have an infrastructure that listens to your Fork ? our jenkins is configured to only build images on this repo not forks...so even if you do all these changes it wont be triggered

The iso build fails because of this bug (as mentioned in the issue description) it was detected in #21997

so I dont see any usage for this modifcations ever !

becasue of this i had to change my fork name to the standard (same as standard repo) name as requested by @nirs
in the conversation log of #21997
who suggested i open this issue in first place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remote for the contributors fork is hardcoded in ISO build process

6 participants