fixup! feat: implement logger actor

Author: nahharris

src/app.rs

@@ -1,5 +1,5 @@
 use crate::{
-    logger::LoggerActor,
+    logger::Logger,
     ui::popup::{info_popup::InfoPopUp, PopUp},
 };
 use ansi_to_tui::IntoText;
@@ -32,7 +32,7 @@ pub mod screens;
 
 /// Type that represents the overall state of the application. It can be viewed
 /// as the **Model** component of `patch-hub`.
-pub struct App<Logger: LoggerActor> {
+pub struct App {
     /// The current active screen
     pub current_screen: CurrentScreen,
     /// Screen to navigate and select the mailing lists archived on Lore
@@ -56,7 +56,7 @@ pub struct App<Logger: LoggerActor> {
     pub logger: Logger,
 }
 
-impl<Logger: LoggerActor> App<Logger> {
+impl App {
     /// Creates a new instance of `App`. It dynamically loads configurations
     /// based on precedence (see [crate::app::Config::build]), app data
     /// (available mailing lists, bookmarked patchsets, reviewed patchsets), and
@@ -65,7 +65,7 @@ impl<Logger: LoggerActor> App<Logger> {
     /// # Returns
     ///
     /// `App` instance with loading configurations and app data.
-    pub fn new(logger: Logger) -> App<Logger> {
+    pub async fn new(logger: Logger) -> App {
         let config: Config = Config::build();
         config.create_dirs();
 
@@ -84,7 +84,7 @@ impl<Logger: LoggerActor> App<Logger> {
 
         // Initialize the logger before the app starts
         logger.info("patch-hub started");
-        logger.collect_garbage();
+        logger.collect_garbage().await;
 
         App {
             current_screen: CurrentScreen::MailingListSelection,

src/cli.rs

@@ -4,7 +4,7 @@ use clap::Parser;
 use color_eyre::eyre::eyre;
 use ratatui::{prelude::Backend, Terminal};
 
-use crate::{app::App, logger::LoggerActor, utils};
+use crate::{app::App, logger::Logger, utils};
 
 #[derive(Debug, Parser)]
 #[command(version, about)]
@@ -21,8 +21,8 @@ impl Cli {
     pub fn resolve<B: Backend>(
         &self,
         terminal: Terminal<B>,
-        app: &mut App<impl LoggerActor>,
-        logger: impl LoggerActor,
+        app: &mut App,
+        logger: Logger,
     ) -> ControlFlow<color_eyre::Result<()>, Terminal<B>> {
         if self.show_configs {
             logger.info("Printing current configurations");

src/handler.rs

@@ -12,7 +12,7 @@ use std::{
 use crate::{
     app::{screens::CurrentScreen, App},
     loading_screen,
-    logger::LoggerActor,
+    logger::Logger,
     ui::draw_ui,
 };
 
@@ -30,7 +30,7 @@ use ratatui::{
 
 fn key_handling<B>(
     mut terminal: Terminal<B>,
-    app: &mut App<impl LoggerActor>,
+    app: &mut App,
     key: KeyEvent,
 ) -> color_eyre::Result<ControlFlow<(), Terminal<B>>>
 where
@@ -64,10 +64,7 @@ where
     Ok(ControlFlow::Continue(terminal))
 }
 
-fn logic_handling<B>(
-    mut terminal: Terminal<B>,
-    app: &mut App<impl LoggerActor>,
-) -> color_eyre::Result<Terminal<B>>
+fn logic_handling<B>(mut terminal: Terminal<B>, app: &mut App) -> color_eyre::Result<Terminal<B>>
 where
     B: Backend + Send + 'static,
 {
@@ -106,11 +103,7 @@ where
     Ok(terminal)
 }
 
-pub fn run_app<B>(
-    mut terminal: Terminal<B>,
-    mut app: App<impl LoggerActor>,
-    logger: impl LoggerActor,
-) -> color_eyre::Result<()>
+pub fn run_app<B>(mut terminal: Terminal<B>, mut app: App, logger: Logger) -> color_eyre::Result<()>
 where
     B: Backend + Send + 'static,
 {

src/handler/bookmarked.rs

@@ -3,7 +3,6 @@ use std::ops::ControlFlow;
 use crate::{
     app::{screens::CurrentScreen, App},
     loading_screen,
-    logger::LoggerActor,
     ui::popup::{help::HelpPopUpBuilder, PopUp},
 };
 use ratatui::{
@@ -13,7 +12,7 @@ use ratatui::{
 };
 
 pub fn handle_bookmarked_patchsets<B>(
-    app: &mut App<impl LoggerActor>,
+    app: &mut App,
     key: KeyEvent,
     mut terminal: Terminal<B>,
 ) -> color_eyre::Result<ControlFlow<(), Terminal<B>>>

src/handler/details_actions.rs

@@ -2,7 +2,6 @@ use std::time::Duration;
 
 use crate::{
     app::{screens::CurrentScreen, App},
-    logger::LoggerActor,
     ui::popup::{help::HelpPopUpBuilder, review_trailers::ReviewTrailersPopUp, PopUp},
     utils,
 };
@@ -15,7 +14,7 @@ use ratatui::{
 use super::wait_key_press;
 
 pub fn handle_patchset_details<B: Backend>(
-    app: &mut App<impl LoggerActor>,
+    app: &mut App,
     key: KeyEvent,
     terminal: &mut Terminal<B>,
 ) -> color_eyre::Result<()> {

src/handler/edit_config.rs

@@ -1,14 +1,10 @@
 use crate::{
     app::{screens::CurrentScreen, App},
-    logger::LoggerActor,
     ui::popup::{help::HelpPopUpBuilder, PopUp},
 };
 use ratatui::crossterm::event::{KeyCode, KeyEvent};
 
-pub fn handle_edit_config(
-    app: &mut App<impl LoggerActor>,
-    key: KeyEvent,
-) -> color_eyre::Result<()> {
+pub fn handle_edit_config(app: &mut App, key: KeyEvent) -> color_eyre::Result<()> {
     if let Some(edit_config_state) = app.edit_config.as_mut() {
         match edit_config_state.is_editing() {
             true => match key.code {

src/handler/latest.rs

@@ -3,7 +3,6 @@ use std::ops::ControlFlow;
 use crate::{
     app::{screens::CurrentScreen, App},
     loading_screen,
-    logger::LoggerActor,
     ui::popup::{help::HelpPopUpBuilder, PopUp},
 };
 use ratatui::{
@@ -13,7 +12,7 @@ use ratatui::{
 };
 
 pub fn handle_latest_patchsets<B>(
-    app: &mut App<impl LoggerActor>,
+    app: &mut App,
     key: KeyEvent,
     mut terminal: Terminal<B>,
 ) -> color_eyre::Result<ControlFlow<(), Terminal<B>>>

src/handler/mail_list.rs

@@ -3,7 +3,6 @@ use std::ops::ControlFlow;
 use crate::{
     app::{screens::CurrentScreen, App},
     loading_screen,
-    logger::LoggerActor,
     ui::popup::{help::HelpPopUpBuilder, PopUp},
 };
 use ratatui::{
@@ -13,7 +12,7 @@ use ratatui::{
 };
 
 pub fn handle_mailing_list_selection<B>(
-    app: &mut App<impl LoggerActor>,
+    app: &mut App,
     key: KeyEvent,
     mut terminal: Terminal<B>,
 ) -> color_eyre::Result<ControlFlow<(), Terminal<B>>>