Skip to content

Commit 93059af

Browse files
Bastian-Krausejluebbe
authored andcommitted
remote: common: list public objects explicitly
labgrid.remote.client and labgrid.remote.coordinator import '*' from labgrid.remote.common. This leads to various modules being imported implicitly. Polluting the namespace like this could overwrite previous local imports or variables. Better specify explicitly what should be imported on '*'. Signed-off-by: Bastian Krause <bst@pengutronix.de>
1 parent 23944c8 commit 93059af

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

labgrid/remote/common.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,16 @@
1010

1111
import attr
1212

13+
__all__ = [
14+
'TAG_KEY',
15+
'TAG_VAL',
16+
'ResourceEntry',
17+
'ResourceMatch',
18+
'Place',
19+
'ReservationState',
20+
'Reservation',
21+
'enable_tcp_nodelay',
22+
]
1323

1424
TAG_KEY = re.compile(r"[a-z][a-z0-9_]+")
1525
TAG_VAL = re.compile(r"[a-z0-9_]?")

0 commit comments

Comments
 (0)