Commit d2addfb
committed
Resolves #4801 ([FR-1778](https://lablup.atlassian.net/browse/FR-1778))
## Summary
- Fixed terminal guide dialog logic in `runTerminal()` to not early return after showing the guide dialog
- Simplified `_openTerminalGuideDialog()` to always show the dialog when called
- This ensures the terminal actually opens when user clicks 'Launch Terminal App' button in the session detail panel
## Test plan
- [ ] Open session detail panel
- [ ] Click 'Launch Terminal App' button
- [ ] Verify terminal opens properly (with or without guide dialog depending on settings)
[FR-1778]: https://lablup.atlassian.net/browse/FR-1778?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
1 parent 6968722 commit d2addfb
1 file changed
+3
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1525 | 1525 | | |
1526 | 1526 | | |
1527 | 1527 | | |
1528 | | - | |
1529 | | - | |
1530 | | - | |
| 1528 | + | |
| 1529 | + | |
1531 | 1530 | | |
1532 | 1531 | | |
1533 | | - | |
1534 | 1532 | | |
1535 | 1533 | | |
1536 | 1534 | | |
| |||
1740 | 1738 | | |
1741 | 1739 | | |
1742 | 1740 | | |
1743 | | - | |
1744 | | - | |
1745 | | - | |
| 1741 | + | |
1746 | 1742 | | |
1747 | 1743 | | |
1748 | 1744 | | |
| |||
0 commit comments