Redirect HTTPS and AutoTLS

[oka-tan]

My func main() is, essentially

      e := echo.New()
      //Middlewares and handlers

      if conf.Production {
            e.AutoTLSManager.HostPolicy = autocert.HostWhitelist(conf.Host)
            e.AutoTLSManager.Cache = autocert.DirCache("/var/www/.cache")
            e.Pre(middleware.HTTPSRedirect())

            e.Logger.Fatal(e.StartAutoTLS(":443"))
      } else {
            e.Logger.Fatal(e.Start(":1323"))
      }

And the AutoTLS works fine, but the redirect doesn't, so when I try to access my host through http it just errors.

I assume that my code is straight up just incorrect, because I'm not specifying where echo should listen for http requests, because I was essentially bundling both examples together, so I would appreciate if anyone could instruct me.

[aldas]

Hi, if this is the only block contains all "echo.Start*" methods that you call I assume problem is that in production mode you are only starting HTTPS listener and are missing open port for HTTP. HTTPS and HTTP are not served on same port.

If you want to have redirect from HTTP to HTTPS you need to start 2 listeners - one for HTTP and one for HTTPS.

[oka-tan]

So I just start a second goroutine that calls e.Logger.Fatal(e.Start(":80")) on the same echo object or do I create a new echo object in a goroutine, use the middleware and call e.Logger.Fatal(e.Start(":80")) on it?

Thanks.

EDIT: The latter works and feels less stupid. Marking question as resolved.

[aldas]

This is untested example with HTTP+HTTPS servers with (graceful)shutdown logic added

func main() {
	e := echo.New()

	e.Use(middleware.Logger())
	e.Use(middleware.Recover())
	e.Pre(middleware.HTTPSRedirect())

	e.GET("/", func(c echo.Context) error {
		return c.String(http.StatusOK, "ok")
	})

	ctx, cancel := signal.NotifyContext(context.Background(), syscall.SIGTERM, os.Interrupt)
	defer cancel()

	wg := sync.WaitGroup{}

	// ------------------------------------- HTTP listener with graceful shutdown -------------------------------------
	httpServer := http.Server{
		Addr:    ":80",
		Handler: e,
	}
	wg.Add(1)
	go func() {
		defer wg.Done()
		if err := httpServer.ListenAndServe(); err != http.ErrServerClosed {
			log.Print(fmt.Errorf("error when starting HTTP server: %w", err))
		} else {
			log.Print("HTTP server stopped")
		}
	}()
	wg.Add(1)
	go func() {
		defer wg.Done()
		<-ctx.Done() // wait for ctrl+c

		timeout, cancel := context.WithTimeout(context.Background(), 5*time.Second)
		defer cancel()
		if err := httpServer.Shutdown(timeout); err != http.ErrServerClosed {
			log.Print(fmt.Errorf("error when shutting HTTP server down: %w", err))
		} else {
			log.Print("HTTP server shut down")
		}
	}()

	// ------------------------------------- HTTPS listener with graceful shutdown -------------------------------------
	autoTLSManager := autocert.Manager{
		//HostPolicy: autocert.HostWhitelist(conf.Host),
		//Prompt: autocert.AcceptTOS,
		Cache: autocert.DirCache("/var/www/.cache"),
	}
	tlsServer := http.Server{
		Addr:    ":443",
		Handler: e,
		TLSConfig: &tls.Config{
			GetCertificate: autoTLSManager.GetCertificate,
			NextProtos:     []string{acme.ALPNProto},
		},
	}
	wg.Add(1)
	go func() {
		defer wg.Done()

		if err := tlsServer.ListenAndServeTLS("", ""); err != http.ErrServerClosed {
			log.Print(fmt.Errorf("error when starting HTTPS server: %w", err))
		} else {
			log.Print("HTTPS server stopped serving requests")
		}
	}()

	wg.Add(1)
	go func() {
		defer wg.Done()
		<-ctx.Done() // wait for ctrl+c

		timeout, cancel := context.WithTimeout(context.Background(), 5*time.Second)
		defer cancel()
		if err := tlsServer.Shutdown(timeout); err != http.ErrServerClosed {
			log.Print(fmt.Errorf("error when shutting HTTPS server down: %w", err))
		} else {
			log.Print("HTTPS server shut down")
		}
	}()

	
	wg.Wait() // wait for all goroutines to end - server listeners and shutdown routines
}