Added feedback when using ! when strict_syntax is set to true

Author: KarlLundengaard

app/evaluation.py

@@ -107,7 +107,9 @@ def check_equality(response, answer, params, eval_response) -> dict:
 
     if params.get("strict_syntax", True):
         if "^" in response:
-            eval_response.add_feedback(("NOTATION_WARNING", symbolic_equal_internal_messages["NOTATION_WARNING"]))
+            eval_response.add_feedback(("NOTATION_WARNING_EXPONENT", symbolic_equal_internal_messages["NOTATION_WARNING_EXPONENT"]))
+        if "!" in response:
+            eval_response.add_feedback(("NOTATION_WARNING_FACTORIAL", symbolic_equal_internal_messages["NOTATION_WARNING_FACTORIAL"]))
 
     # Safely try to parse answer and response into symbolic expressions
     try:

app/evaluation_tests.py

@@ -615,12 +615,13 @@ def test_numerical_comparison(self, description, response, answer, tolerance, ou
         assert result["is_correct"] is outcome
 
     def test_warning_inappropriate_symbol(self):
-        answer = '2**4'
-        response = '2^4'
+        answer = 'factorial(2**4)'
+        response = '2^4!'
         params = {'strict_syntax': True}
         result = evaluation_function(response, answer, params, include_test_data=True)
         assert result["is_correct"] is False
-        assert "NOTATION_WARNING" in result["tags"]
+        assert "NOTATION_WARNING_EXPONENT" in result["tags"]
+        assert "NOTATION_WARNING_FACTORIAL" in result["tags"]
 
     @pytest.mark.parametrize(
         "response,answer",

app/feedback/symbolic_equal.py

@@ -6,7 +6,8 @@
     "MULTIPLE_ANSWER_FAIL_RESPONSE": "At least one response was incorrect.",
     "MULTIPLE_ANSWER_FAIL_ANSWERS": "At least one answer is missing in the response.",
     "PARSE_ERROR": lambda x: f"`{x}` could not be parsed as a valid mathematical expression. Ensure that correct codes for input symbols are used, correct notation is used, that the expression is unambiguous and that all parentheses are closed.",
-    "NOTATION_WARNING": "Note that `^` cannot be used to denote exponentiation, use `**` instead.",
+    "NOTATION_WARNING_EXPONENT": "Note that `^` cannot be used to denote exponentiation, use `**` instead.",
+    "NOTATION_WARNING_FACTORIAL": "Note that `!` cannot be used to denote factorial, use `factorial(...)` instead.",
     "EXPRESSION_NOT_EQUALITY": "The response was an expression but was expected to be an equality.",
     "EQUALITY_NOT_EXPRESSION": "The response was an equality but was expected to be an expression.",
     "WITHIN_TOLERANCE": "",  # "The difference between the response the answer is within specified error tolerance.",