You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
uri is part of a growing collection of quality Clojure libraries created and maintained
24
31
by the fine folks at [Gaiwan](https://gaiwan.co).
25
32
26
-
Pay it forward by [becoming a backer on our Open Collective](http://opencollective.com/lambda-island),
27
-
so that we may continue to enjoy a thriving Clojure ecosystem.
33
+
Pay it forward by [becoming a backer on our OpenCollective](http://opencollective.com/lambda-island),
34
+
so that we continue to enjoy a thriving Clojure ecosystem.
28
35
29
-
You can find an overview of our projects at [lambdaisland/open-source](https://github.com/lambdaisland/open-source).
36
+
You can find an overview of all our different projects at [lambdaisland/open-source](https://github.com/lambdaisland/open-source).
30
37
31
38
32
39
@@ -166,39 +173,35 @@ It has been tested against [this list of test cases compiled by the W3C](https:/
166
173
<!-- contributing -->
167
174
## Contributing
168
175
169
-
Everyone has a right to submit patches to uri, and thus become a contributor.
170
-
171
-
Contributors MUST
176
+
We warmly welcome patches to uri. Please keep in mind the following:
172
177
173
178
- adhere to the [LambdaIsland Clojure Style Guide](https://nextjournal.com/lambdaisland/clojure-style-guide)
174
-
- write patches that solve a problem. Start by stating the problem, then supply a minimal solution. `*`
175
-
- agree to license their contributions as MPL 2.0.
176
-
- not break the contract with downstream consumers. `**`
177
-
- not break the tests.
179
+
- write patches that solve a problem
180
+
- start by stating the problem, then supply a minimal solution `*`
181
+
- by contributing you agree to license your contributions as MPL 2.0
182
+
- don't break the contract with downstream consumers `**`
183
+
- don't break the tests
178
184
179
-
Contributors SHOULD
185
+
We would very much appreciate it if you also
180
186
181
-
- update the CHANGELOG and README.
182
-
- add tests for new functionality.
187
+
- update the CHANGELOG and README
188
+
- add tests for new functionality
183
189
184
-
If you submit a pull request that adheres to these rules, then it will almost
185
-
certainly be merged immediately. However some things may require more
186
-
consideration. If you add new dependencies, or significantly increase the API
187
-
surface, then we need to decide if these changes are in line with the project's
188
-
goals. In this case you can start by [writing a pitch](https://nextjournal.com/lambdaisland/pitch-template),
189
-
and collecting feedback on it.
190
+
We recommend opening an issue first, before opening a pull request. That way we
191
+
can make sure we agree what the problem is, and discuss how best to solve it.
192
+
This is especially true if you add new dependencies, or significantly increase
193
+
the API surface. In cases like these we need to decide if these changes are in
194
+
line with the project's goals.
190
195
191
-
`*` This goes for features too, a feature needs to solve a problem. State the problem it solves, then supply a minimal solution.
196
+
`*` This goes for features too, a feature needs to solve a problem. State the problem it solves first, only then move on to solving it.
192
197
193
-
`**` As long as this project has not seen a public release (i.e. is not on Clojars)
194
-
we may still consider making breaking changes, if there is consensus that the
195
-
changes are justified.
198
+
`**` Projects that have a version that starts with `0.` may still see breaking changes, although we also consider the level of community adoption. The more widespread a project is, the less likely we're willing to introduce breakage. See [LambdaIsland-flavored Versioning](https://github.com/lambdaisland/open-source#lambdaisland-flavored-versioning) for more info.
0 commit comments