Skip to content

fix(deepseek): handle array inputs #34228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davecrunch wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −2
Open

fix(deepseek): handle array inputs #34228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dde2220
converting arrays to strings for deepseek, modified tests too
davecrunch Dec 5, 2025
6c4b0a7
Merge branch 'master' into woodytestbranch
davecrunch Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion libs/partners/deepseek/langchain_deepseek/chat_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,12 @@ def _get_request_payload(
payload = super()._get_request_payload(input_, stop=stop, **kwargs)
for message in payload["messages"]:
if message["role"] == "tool" and isinstance(message["content"], list):
message["content"] = json.dumps(message["content"])
# DeepSeek API expects tool message content to be a string, not a list.
# Convert empty arrays to empty string, non-empty arrays to JSON string.
if not message["content"]:
message["content"] = ""
else:
message["content"] = json.dumps(message["content"])
elif message["role"] == "assistant" and isinstance(
message["content"], list
):
Expand Down
5 changes: 4 additions & 1 deletion libs/partners/deepseek/tests/unit_tests/test_chat_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,14 +232,17 @@ def test_get_request_payload(self) -> None:
"""Test that tool message content is converted from list to string."""
chat_model = ChatDeepSeek(model=MODEL_NAME, api_key=SecretStr("api_key"))

# Empty array should be converted to empty string (not JSON string "[]")
tool_message = ToolMessage(content=[], tool_call_id="test_id")
payload = chat_model._get_request_payload([tool_message])
assert payload["messages"][0]["content"] == "[]"
assert payload["messages"][0]["content"] == ""

# Non-empty array should be converted to JSON string
tool_message = ToolMessage(content=["item1", "item2"], tool_call_id="test_id")
payload = chat_model._get_request_payload([tool_message])
assert payload["messages"][0]["content"] == '["item1", "item2"]'

# String content should remain unchanged
tool_message = ToolMessage(content="test string", tool_call_id="test_id")
payload = chat_model._get_request_payload([tool_message])
assert payload["messages"][0]["content"] == "test string"
Expand Down
Loading