|
| 1 | +package tempfile_test |
| 2 | + |
| 3 | +import ( |
| 4 | + "os" |
| 5 | + "path/filepath" |
| 6 | + "testing" |
| 7 | + |
| 8 | + "github.com/lanrat/extsort/tempfile" |
| 9 | +) |
| 10 | + |
| 11 | +func TestDirectorySharing(t *testing.T) { |
| 12 | + // Test that multiple writers share the same directory when using intelligent directory selection |
| 13 | + |
| 14 | + // Create first writer - this will use the intelligent directory selection |
| 15 | + writer1, err := tempfile.New("", true) |
| 16 | + if err != nil { |
| 17 | + t.Fatalf("Failed to create first tempfile writer: %v", err) |
| 18 | + } |
| 19 | + |
| 20 | + // Get the directory that was actually used |
| 21 | + dir1 := filepath.Dir(writer1.Name()) |
| 22 | + t.Logf("First writer using directory: %s", dir1) |
| 23 | + |
| 24 | + // Create second writer with same parameters - should use same directory if it's cached |
| 25 | + writer2, err := tempfile.New("", true) |
| 26 | + if err != nil { |
| 27 | + t.Fatalf("Failed to create second tempfile writer: %v", err) |
| 28 | + } |
| 29 | + |
| 30 | + dir2 := filepath.Dir(writer2.Name()) |
| 31 | + t.Logf("Second writer using directory: %s", dir2) |
| 32 | + |
| 33 | + // Both should use the same directory due to caching |
| 34 | + if dir1 != dir2 { |
| 35 | + t.Errorf("Expected both writers to use same directory, got %s and %s", dir1, dir2) |
| 36 | + } |
| 37 | + |
| 38 | + // The directory should exist |
| 39 | + if _, err := os.Stat(dir1); os.IsNotExist(err) { |
| 40 | + t.Fatalf("Expected directory %s to exist", dir1) |
| 41 | + } |
| 42 | + |
| 43 | + // Close first writer |
| 44 | + err = writer1.Close() |
| 45 | + if err != nil { |
| 46 | + t.Fatalf("Failed to close first writer: %v", err) |
| 47 | + } |
| 48 | + |
| 49 | + // Directory should still exist |
| 50 | + if _, err := os.Stat(dir1); os.IsNotExist(err) { |
| 51 | + t.Errorf("Expected directory %s to still exist after closing first writer", dir1) |
| 52 | + } |
| 53 | + |
| 54 | + // Close second writer |
| 55 | + err = writer2.Close() |
| 56 | + if err != nil { |
| 57 | + t.Fatalf("Failed to close second writer: %v", err) |
| 58 | + } |
| 59 | + |
| 60 | + // Check final state - the behavior depends on whether we created the directory |
| 61 | + _, err = os.Stat(dir1) |
| 62 | + dirStillExists := !os.IsNotExist(err) |
| 63 | + |
| 64 | + t.Logf("Directory %s still exists after all writers closed: %t", dir1, dirStillExists) |
| 65 | + |
| 66 | + // This test documents the behavior rather than asserting specific cleanup |
| 67 | + // The important guarantee is that temp files are cleaned up, not necessarily the directories |
| 68 | +} |
| 69 | + |
| 70 | +func TestDirectoryReferenceCountingCleanup(t *testing.T) { |
| 71 | + // Test directory reference counting behavior with user-specified directories |
| 72 | + |
| 73 | + // Create a base test directory |
| 74 | + baseDir, err := os.MkdirTemp("", "extsort-cleanup-test-") |
| 75 | + if err != nil { |
| 76 | + t.Fatalf("Failed to create test base dir: %v", err) |
| 77 | + } |
| 78 | + defer os.RemoveAll(baseDir) |
| 79 | + |
| 80 | + // Create a subdirectory that matches our process-specific pattern |
| 81 | + // This simulates what would happen in the fallback case |
| 82 | + testDir := filepath.Join(baseDir, "test-extsort-dir") |
| 83 | + |
| 84 | + // Don't create the directory - let tempfile.New create it |
| 85 | + |
| 86 | + // Create first writer in the test directory |
| 87 | + writer1, err := tempfile.New(testDir, true) |
| 88 | + if err != nil { |
| 89 | + t.Fatalf("Failed to create first tempfile writer: %v", err) |
| 90 | + } |
| 91 | + |
| 92 | + // Verify directory was created |
| 93 | + if _, err := os.Stat(testDir); os.IsNotExist(err) { |
| 94 | + t.Fatalf("Expected directory %s to be created", testDir) |
| 95 | + } |
| 96 | + |
| 97 | + // Create second writer in the same directory |
| 98 | + writer2, err := tempfile.New(testDir, true) |
| 99 | + if err != nil { |
| 100 | + t.Fatalf("Failed to create second tempfile writer: %v", err) |
| 101 | + } |
| 102 | + |
| 103 | + // Both writers should be in the same directory |
| 104 | + dir1 := filepath.Dir(writer1.Name()) |
| 105 | + dir2 := filepath.Dir(writer2.Name()) |
| 106 | + if dir1 != testDir || dir2 != testDir { |
| 107 | + t.Errorf("Expected both writers in %s, got %s and %s", testDir, dir1, dir2) |
| 108 | + } |
| 109 | + |
| 110 | + // Close first writer - directory should still exist |
| 111 | + err = writer1.Close() |
| 112 | + if err != nil { |
| 113 | + t.Fatalf("Failed to close first writer: %v", err) |
| 114 | + } |
| 115 | + |
| 116 | + // Directory should still exist because second writer is using it |
| 117 | + if _, err := os.Stat(testDir); os.IsNotExist(err) { |
| 118 | + t.Errorf("Expected directory %s to still exist after closing first writer", testDir) |
| 119 | + } |
| 120 | + |
| 121 | + // Close second writer |
| 122 | + err = writer2.Close() |
| 123 | + if err != nil { |
| 124 | + t.Fatalf("Failed to close second writer: %v", err) |
| 125 | + } |
| 126 | + |
| 127 | + // Since this isn't a process-specific extsort directory, it should still exist |
| 128 | + // (We only clean up directories that match our specific naming pattern) |
| 129 | + if _, err := os.Stat(testDir); os.IsNotExist(err) { |
| 130 | + t.Errorf("Expected directory %s to still exist after closing all writers (not an extsort-specific dir)", testDir) |
| 131 | + } |
| 132 | +} |
0 commit comments