add missing tests for errors and grover

Author: lazyoracle

src/isotropic/algos/grover.py

@@ -77,7 +77,7 @@ def get_grover_answer(result: PrimitiveResult) -> tuple[dict, str]:
         A tuple containing the counts dictionary and the most probable search item.
     """
     if not isinstance(result, PrimitiveResult):
-        raise ValueError("The result must be an instance of PrimitiveResult.")
+        raise TypeError("The result must be an instance of PrimitiveResult.")
 
     counts = result[0].data.c0.get_counts()
     grover_answer = max(counts, key=counts.get)

src/isotropic/utils/distribution.py

@@ -80,7 +80,7 @@ def double_factorial_ratio_jax(num: int, den: int) -> Array:
     For very large numbers, this is numerically stable only when |num - den| is ~5.
     """
     warnings.warn(
-        "This is an experimental implementation. There are known issues when with using this for numbers larger than 2**8",
+        "This is an experimental implementation. There are known issues with using this for numbers larger than 2**8",
         UserWarning,
     )
     if abs(num - den) > 4:

tests/test_grover.py

@@ -0,0 +1,39 @@
+import pytest
+from qiskit.primitives import StatevectorSampler
+from qiskit.quantum_info import Operator
+
+from isotropic.algos.grover import (
+    get_grover_answer,
+    get_grover_circuit,
+    optimal_num_iterations,
+)
+
+U_w = Operator(
+    [
+        [1, 0, 0, 0, 0, 0, 0, 0],
+        [0, 1, 0, 0, 0, 0, 0, 0],
+        [0, 0, 1, 0, 0, 0, 0, 0],
+        [0, 0, 0, -1, 0, 0, 0, 0],
+        [0, 0, 0, 0, 1, 0, 0, 0],
+        [0, 0, 0, 0, 0, 1, 0, 0],
+        [0, 0, 0, 0, 0, 0, 1, 0],
+        [0, 0, 0, 0, 0, 0, 0, 1],
+    ]
+)
+
+
+def test_grover_integration():
+    num_qubits = 3
+    optimal_iterations = optimal_num_iterations(num_solutions=1, num_qubits=num_qubits)
+    grover_circuit = get_grover_circuit(num_qubits, U_w, optimal_iterations)
+    grover_circuit.measure_all(add_bits=False)
+    statevectorsampler = StatevectorSampler()
+    result = statevectorsampler.run([grover_circuit]).result()
+    _, answer = get_grover_answer(result)
+    assert answer == "011", f"Expected '011', got {answer}"
+
+    with pytest.raises(ValueError):  # check wrong number of qubits error
+        get_grover_circuit(num_qubits=4, U_w=U_w, iterations=optimal_iterations)
+
+    with pytest.raises(TypeError):  # check wrong result datatype error
+        get_grover_answer(result[0])

tests/test_utils.py

@@ -1,11 +1,13 @@
 import jax.numpy as jnp
+import pytest
 from scipy.linalg import null_space
 from scipy.special import factorial2
 
 from isotropic.utils.bisection import get_theta
 from isotropic.utils.distribution import (
     double_factorial_jax,
     double_factorial_ratio_jax,
+    double_factorial_ratio_scipy,
     normal_integrand,
 )
 from isotropic.utils.linalg import jax_null_space
@@ -99,6 +101,14 @@ def test_double_factorial_ratio_jax():
         f"Expected {ratio_expected}, got {ratio_received}"
     )
 
+    with pytest.raises(ValueError):  # check for error on inputs not close enough
+        _ = double_factorial_ratio_jax(300, 290)
+
+
+def test_double_factorial_ratio_scipy():
+    with pytest.raises(ValueError):
+        _ = double_factorial_ratio_scipy(302, 301)
+
 
 def test_normal_integrand():
     theta = jnp.pi / 4  # 45 degrees