Skip to content

Commit 2ca8cec

Browse files
authored
Fix debug screen lists implementation (#119)
Fix debug screen lists implementation
1 parent 519abc5 commit 2ca8cec

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

src/main/java/com/ldtteam/blockui/mod/ClientEventSubscriber.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ private static Button createTestGuiButton(final int order,
131131
final ResourceLocation testGuiResLoc,
132132
final Consumer<BOWindow>... setups)
133133
{
134-
final Button button = new ButtonImage();
134+
final Button button = new ButtonImage(true);
135135
button.setPosition((order % 2) * (button.getWidth() + 20), (order / 2) * (button.getHeight() + 10));
136136
button.setText(Component.literal(name));
137137
button.setHandler(b -> {

src/main/java/com/ldtteam/blockui/mod/ScrollingListsGui.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
import java.util.ArrayList;
1515
import java.util.List;
1616
import java.util.UUID;
17-
import java.util.concurrent.atomic.AtomicBoolean;
1817
import java.util.concurrent.atomic.AtomicInteger;
1918

2019
/**
@@ -131,7 +130,6 @@ public void updateElement(final int index, final Pane rowPane)
131130
window.findPaneOfTypeByID("list4remove", Button.class).setHandler(button -> renderAmount.getAndAdd(-2));
132131

133132
// Case 5: A list that will not update
134-
final AtomicBoolean shouldRenderFlag = new AtomicBoolean();
135133
final ScrollingList list5 = window.findPaneOfTypeByID("list5", ScrollingList.class);
136134
list5.setDataProvider(new DataProvider()
137135
{
@@ -144,17 +142,16 @@ public int getElementCount()
144142
@Override
145143
public boolean shouldUpdate()
146144
{
147-
return shouldRenderFlag.get();
145+
return false;
148146
}
149147

150148
@Override
151149
public void updateElement(final int index, final Pane rowPane)
152150
{
153-
shouldRenderFlag.set(false);
154151
rowPane.findPaneByType(Text.class).setText(Component.literal("Hi " + index + " " + UUID.randomUUID()));
155152
}
156153
});
157154

158-
window.findPaneOfTypeByID("list5update", Button.class).setHandler(button -> shouldRenderFlag.set(true));
155+
window.findPaneOfTypeByID("list5update", Button.class).setHandler(button -> list5.refreshElementPanes(true));
159156
}
160157
}

src/main/resources/assets/blockui/gui/test4.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
<button id="list4add" pos="480 200" size="160 20" label="Add item"/>
2323
<button id="list4remove" pos="480 220" size="160 20" label="Remove item"/>
2424
<list id="list5" size="160 200" pos="0 240" emptytext="This list is empty" emptyscale="0.8" emptycolor="white">
25-
<label size="152 20"/>
25+
<text size="152 20"/>
2626
</list>
2727
<button id="list5update" pos="0 440" size="160 20" label="Update list"/>
28-
</window>
28+
</window>

0 commit comments

Comments
 (0)