feat: support mmap for model loading #1059
Draft
+182
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new
--use-mmapflag that replaces model loading I/O operations withmmap+memcpy.In my tests, this helps model loading speed slightly, though the gain was never higher than half a second. Its primary benefit right now is validation of the
mmapbackend implementation. Later, I plan to extend this to allow the mapped file to serve directly as weight storage for backends that use main memory.I used a non-default flag to be extra safe, but we could arguably follow llama.cpp approach, with a
--no-mmapflag to disable it instead.I was only able to test (and build...) it under Linux, so additional testing is very welcome 🙂