Skip to content

Commit 5e1a74c

Browse files
authored
Fix Windows Edge browser setup (#485)
Extra pair of quotes breaks the setup. The browser does not get detected. Aligning with the other browsers. ES and CN were missing the browser setting completely. The $BROWSER is needed in the data-setup, which uses the web setup partials.
1 parent 5ec53db commit 5e1a74c

File tree

5 files changed

+5
-4
lines changed

5 files changed

+5
-4
lines changed

_partials/cn/windows_browser.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@
7171

7272

7373
```bash
74+
echo "export BROWSER=\"/mnt/c/Program Files (x86)/Microsoft/Edge/Application/msedge.exe\"" >> ~/.zshrc
7475
echo "export GH_BROWSER=\"'/mnt/c/Program Files (x86)/Microsoft/Edge/Application/msedge.exe'\"" >> ~/.zshrc
7576
```
7677
</details>

_partials/es/windows_browser.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ Para asegurarnos de que puedas interactuar desde la terminal de Ubuntu con el na
5858
Ejecuta el siguiente comandos:
5959

6060
```bash
61+
echo "export BROWSER=\"/mnt/c/Program Files (x86)/Microsoft/Edge/Application/msedge.exe\"" >> ~/.zshrc
6162
echo "export GH_BROWSER=\"'/mnt/c/Program Files (x86)/Microsoft/Edge/Application/msedge.exe'\"" >> ~/.zshrc
6263
```
6364
</details>

_partials/fr/windows_browser.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ Si tu obtiens une erreur du type `ls: cannot access...`, exécute la commande su
5858
Exécute la commandes :
5959

6060
```bash
61-
echo "export BROWSER='\"/mnt/c/Program Files (x86)/Microsoft/Edge/Application/msedge.exe\"'" >> ~/.zshrc
61+
echo "export BROWSER=\"/mnt/c/Program Files (x86)/Microsoft/Edge/Application/msedge.exe\"" >> ~/.zshrc
6262
echo "export GH_BROWSER=\"'/mnt/c/Program Files (x86)/Microsoft/Edge/Application/msedge.exe'\"" >> ~/.zshrc
6363
```
6464
</details>

_partials/pt/windows_browser.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ Execute os seguintes comandos:
8585
Execute os comandos:
8686

8787
```bash
88-
echo "export BROWSER='\"/mnt/c/Program Files (x86)/Microsoft/Edge/Application/msedge.exe\"'" >> ~/.zshrc
88+
echo "export BROWSER=\"/mnt/c/Program Files (x86)/Microsoft/Edge/Application/msedge.exe\"" >> ~/.zshrc
8989
echo "export GH_BROWSER=\"'/mnt/c/Program Files (x86)/Microsoft/Edge/Application/msedge.exe'\"" >> ~/.zshrc
9090
```
9191

_partials/windows_browser.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ Run the following commands:
8585
Run the commands:
8686

8787
```bash
88-
echo "export BROWSER='\"/mnt/c/Program Files (x86)/Microsoft/Edge/Application/msedge.exe\"'" >> ~/.zshrc
88+
echo "export BROWSER=\"/mnt/c/Program Files (x86)/Microsoft/Edge/Application/msedge.exe\"" >> ~/.zshrc
8989
echo "export GH_BROWSER=\"'/mnt/c/Program Files (x86)/Microsoft/Edge/Application/msedge.exe'\"" >> ~/.zshrc
9090
```
9191

@@ -112,4 +112,3 @@ exec zsh
112112
```
113113

114114
Do not hesitate to **contact a teacher**.
115-

0 commit comments

Comments
 (0)