Skip to content

Commit e2f10ba

Browse files
author
Teseo Schneider
committed
fixed intrisinc test
1 parent 5a597f7 commit e2f10ba

File tree

3 files changed

+17
-6
lines changed

3 files changed

+17
-6
lines changed

src/intrinsic_delaunay_triangulation.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
#include <common.h>
22
#include <npe.h>
33
#include <typedefs.h>
4+
#include <pybind11/stl.h>
45
#include <igl/intrinsic_delaunay_triangulation.h>
56

67
const char *ds_intrinsic_delaunay_triangulation = R"igl_Qu8mg5v7(

src/sharp_edges.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ angle dihedral angle considered to sharp (e.g., igl::PI * 0.11)
1717
Returns
1818
-------
1919
SE #SE by 2 list of edge indices into V
20+
E #e by 2 list of edges in no particular order
2021
uE #uE by 2 list of unique undirected edges
2122
EMAP #F*3 list of indices into uE, mapping each directed edge to unique
2223
undirected edge so that uE(EMAP(f+#F*c)) is the unique edge

tests/test_basic.py

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,16 @@ def setUp(self):
3030
self.f = np.random.randint(0, 10, size=(20, 3), dtype=self.f1.dtype)
3131
self.g = np.random.randint(0, 10, size=(20, 4), dtype="int32")
3232

33+
def tearDown(self):
34+
vv1, ff1 = igl.read_triangle_mesh(os.path.join(self.test_path, "bunny_small.off"))
35+
vv2, ff2 = igl.read_triangle_mesh(os.path.join(self.test_path, "fertility.off"))
36+
self.assertTrue((vv1 == self.v1).all())
37+
self.assertTrue((ff1 == self.f1).all())
38+
39+
self.assertTrue((vv2 == self.v2).all())
40+
self.assertTrue((ff2 == self.f2).all())
41+
42+
3343
def test_z_module(self):
3444
# Extract all implemented functions from the module
3545
funcs = []
@@ -1616,11 +1626,11 @@ def test_intrinsic_delaunay_triangulation(self):
16161626
self.assertTrue(f.shape[1] == 3)
16171627

16181628
def test_intrinsic_delaunay_triangulation_edges(self):
1619-
el = igl.edge_lengths(self.v, self.f)
1620-
l, f, e, u_e, emap, ue2e = igl.intrinsic_delaunay_triangulation_edges(el, self.f)
1621-
#self.assertTrue(f.flags.c_contiguous)
1622-
#self.assertTrue(f.dtype == self.f.dtype)
1623-
#self.assertTrue(f.shape[1] == 3)
1629+
el = igl.edge_lengths(self.v1, self.f1)
1630+
l, f, e, u_e, emap, ue2e = igl.intrinsic_delaunay_triangulation_edges(el, self.f1)
1631+
self.assertTrue(f.flags.c_contiguous)
1632+
self.assertTrue(f.dtype == self.f.dtype)
1633+
self.assertTrue(f.shape[1] == 3)
16241634

16251635
def test_edges_to_path(self):
16261636
e = igl.edges(self.f1)
@@ -2214,7 +2224,6 @@ def test_rigid_alignment(self):
22142224
self.assertTrue(r.dtype == t.dtype == self.v1.dtype)
22152225

22162226
def test_sharp_edges(self):
2217-
# TODO IGL documentation misses second return parameter e, fix in igl
22182227
se, e, ue, emap, ue2e, sharp = igl.sharp_edges(self.v1, self.f1, np.pi*0.11)
22192228
self.assertTrue(se.shape[1] == 2)
22202229
self.assertTrue(ue.shape[1] == 2)

0 commit comments

Comments
 (0)