Drop a character less

raboof · raboof · commit 6eefdc7163d2 · 2019-08-21T21:26:55.000+02:00
diff --git a/core/src/main/scala/com/typesafe/tools/mima/lib/analyze/method/MethodChecker.scala b/core/src/main/scala/com/typesafe/tools/mima/lib/analyze/method/MethodChecker.scala
@@ -47,7 +47,10 @@ private[analyze] object BaseMethodChecker {
   oldSignature == newSignature ||
     // Special case for https://github.com/scala/scala/pull/7975:
     (bytecodeName == MemberInfo.ConstructorName &&
-      (newSignature.isEmpty || (oldSignature.endsWith(newSignature.drop(2))))
+      (newSignature.isEmpty ||
+        // The dropped character is the leading '('
+        oldSignature.endsWith(newSignature.tail)
+      )
     )
 }
 

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,10 @@ private[analyze] object BaseMethodChecker {`
`47`	`47`	`oldSignature == newSignature \|\|`
`48`	`48`	`// Special case for https://github.com/scala/scala/pull/7975:`
`49`	`49`	`(bytecodeName == MemberInfo.ConstructorName &&`
`50`		`- (newSignature.isEmpty \|\| (oldSignature.endsWith(newSignature.drop(2))))`
	`50`	`+ (newSignature.isEmpty \|\|`
	`51`	`+ // The dropped character is the leading '('`
	`52`	`+ oldSignature.endsWith(newSignature.tail)`
	`53`	`+ )`
`51`	`54`	`)`
`52`	`55`	`}`
`53`	`56`