pay: correct check for payment error on payment attempt

Roasbeef · Roasbeef · commit 27b58ec02a44 · 2017-09-13T14:42:39.000+02:00
Previously, we checked against a null value, while within the proto
itself, the error is actually a string. To fix this, we properly check
against an empty string. With this commit, payment errors will now
properly display.
diff --git a/packages/lightning-core/pay/reducer.js b/packages/lightning-core/pay/reducer.js
@@ -48,11 +48,11 @@ export const actions = {
         .then(() => {
           const payments = dispatch(actions.sendPayment())
           payments.on('data', function(payment) {
-              if (payment.payment_error != null) {
                   rejectError 
               }
               else {
                   resolveSuccess
+              if (payment.payment_error != "") {
               }
           })
           payments.on('error', rejectError)

Original file line number	Diff line number	Diff line change
`@@ -48,11 +48,11 @@ export const actions = {`
`48`	`48`	`.then(() => {`
`49`	`49`	`const payments = dispatch(actions.sendPayment())`
`50`	`50`	`payments.on('data', function(payment) {`
`51`		`- if (payment.payment_error != null) {`
`52`	`51`	`rejectError`
`53`	`52`	`}`
`54`	`53`	`else {`
`55`	`54`	`resolveSuccess`
	`55`	`+ if (payment.payment_error != "") {`
`56`	`56`	`}`
`57`	`57`	`})`
`58`	`58`	`payments.on('error', rejectError)`