Merge pull request #1045 from lightninglabs/exchange-rate-api

Use new exchange rate api

Author: valentinewallace

src/action/wallet.js

@@ -504,9 +504,12 @@ class WalletAction {
   async getExchangeRate() {
     try {
       const fiat = this._store.settings.fiat;
-      const uri = `https://blockchain.info/tobtc?currency=${fiat}&value=1`;
+      const uri =
+        'https://nodes.lightning.computer/fiat/v1/btc-exchange-rates.json';
       const response = checkHttpStatus(await fetch(uri));
-      this._store.settings.exchangeRate[fiat] = Number(await response.text());
+      const tickers = (await response.json()).tickers;
+      const rate = tickers.find(t => t.ticker.toLowerCase() === fiat).rate;
+      this._store.settings.exchangeRate[fiat] = 100 / rate;
       this._db.save();
     } catch (err) {
       log.error('Getting exchange rate failed', err);

test/unit/action/wallet.spec.js

@@ -597,20 +597,38 @@ describe('Action Wallet Unit Tests', () => {
   });
 
   describe('getExchangeRate()', () => {
+    const json = `{
+      "tickers": [
+        {
+          "date": "2019-04-04T03:30:05.000Z",
+          "rate": 443302,
+          "ticker": "EUR"
+        },
+        {
+          "date": "2019-04-04T03:30:05.000Z",
+          "rate": 378294,
+          "ticker": "GBP"
+        },
+        {
+          "date": "2019-04-04T03:30:05.000Z",
+          "rate": 498467,
+          "ticker": "USD"
+        }
+      ]
+    }`;
+
     it('should get exchange rate', async () => {
-      nock('https://blockchain.info')
-        .get('/tobtc')
-        .query({ currency: 'usd', value: 1 })
-        .reply(200, '0.00011536');
+      nock('https://nodes.lightning.computer')
+        .get('/fiat/v1/btc-exchange-rates.json')
+        .reply(200, json);
       await wallet.getExchangeRate();
-      expect(store.settings.exchangeRate.usd, 'to be', 0.00011536);
+      expect(store.settings.exchangeRate.usd, 'to be', 0.000200615085853226);
       expect(db.save, 'was called once');
     });
 
     it('should display notification on error', async () => {
-      nock('https://blockchain.info')
-        .get('/tobtc')
-        .query({ currency: 'usd', value: 1 })
+      nock('https://nodes.lightning.computer')
+        .get('/fiat/v1/btc-exchange-rates.json')
         .reply(500, 'Boom!');
       await wallet.getExchangeRate();
       expect(store.settings.exchangeRate.usd, 'to be', undefined);