Fix FlatMap implementation in Result type #10403
Open
+139
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
For a Result[T], FlatMap should apply f when the result is Ok, and propagate the error unchanged when it's Err. The original code returns r on Ok and tries to use r.left when Err, which is wrong. This commit fixes that. Secondly, the group of FlatMap/AndThen and OrElse functions and methods are now properly tested with new unit tests. fixes lightningnetwork#10401
gijswijs
force-pushed
the
fix-flatmap
branch
from
ddbb18f to
7eb0728
Compare
gijswijs
changed the title
Collaborator
Author
|
The coveralls checks failing are a false positive. Coverage before: After: |
ziggie1984
approved these changes
Dec 2, 2025
Collaborator
ziggie1984
left a comment
ziggie1984
left a comment
There was a problem hiding this comment.
some code style minor nits - otherwise LGTM
| // Since AndThen is just an alias for FlatMap, we can reuse the same | ||
| // test cases. | ||
| for _, tc := range flatMapTestCases { | ||
| tc := tc |
Collaborator
There was a problem hiding this comment.
that is not needed anymore in golang > 1.19 I think
Collaborator
There was a problem hiding this comment.
can also be removed for all the following lines.
| addresses](https://github.com/lightningnetwork/lnd/pull/10341) were added to | ||
| the node announcement and `getinfo` output. | ||
|
|
||
| * A bug in the [implementation of |
Collaborator
There was a problem hiding this comment.
not sure if we need release notes, since this function was not used in the LND release anyways, just add a no-changelog label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FlatMapmethod for theResulttype has been corrected to apply the provided function when the result isOkand propagate the error unchanged when it isErr.Comprehensive unit tests have been added to ensure proper functionality of FlatMap, AndThen, and OrElse methods.
Fixes #10401