terraform: Add fixed storage pathnames for all providers

Now that all cloud providers have consistent device pathnames for
the extra volumes created by terraform, we can make setting the
"data" and "sparse" device names consistent as well.

These symbolic constants can then be used by the volume_group and
devconfig playbooks and the fstests workflow to reliably locate
their block device resources on test runners in the cloud.

Follow the design of the OCI provider and expose the device
pathnames for the data and sparse device so these pathnames can
be used reliably by other kdevops subsystems.

Note that the AWS data volume default, which was hidden in the
Kconfig menu, changes from "/dev/nvme1n1" to
"/dev/disk/kdevops/extra-volume-00." Existing AWS configurations
might break if they depend on the old pathname. Also, "make
menuconfig" by itself does not change the existing value of
TERRAFORM_AWS_DATA_VOLUME_DEVICE_FILE_NAME to the new string.
Users must make that adjustment manually in existing defconfig
files.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

Author: chucklever

terraform/aws/kconfigs/Kconfig.storage

@@ -203,5 +203,18 @@ config TERRAFORM_AWS_EBS_VOLUME_SIZE
 	default 4096 if TERRAFORM_AWS_EBS_VOLUME_SIZE_4096G
 
 config TERRAFORM_AWS_DATA_VOLUME_DEVICE_FILE_NAME
-	string
-	default "/dev/nvme1n1"
+	string "Data volume's device file name"
+	output yaml
+	default "/dev/disk/kdevops/extra-volume-00"
+	help
+	  This option sets the name of the block device on each
+	  target node that is to be used for the /data file system.
+
+config TERRAFORM_AWS_SPARSE_VOLUME_DEVICE_FILE_NAME
+	string "Sparse volume's device file name"
+	output yaml
+	default "/dev/disk/kdevops/extra-volume-01"
+	help
+	  This option sets the name of the block device on each
+	  target node that can be used for the fstests sparse device
+	  tests.

terraform/azure/kconfigs/Kconfig.storage

@@ -212,8 +212,18 @@ config TERRAFORM_AZURE_MANAGED_DISKS_TIER
 	default "P50" if TERRAFORM_AZURE_MANAGED_DISKS_TIER_P50
 
 config TERRAFORM_AZURE_DATA_VOLUME_DEVICE_FILE_NAME
-	string "Device name for the /data file system"
+	string "Data volume's device file name"
+	output yaml
 	default "/dev/disk/azure/scsi1/lun0"
 	help
-	  This option sets the name of the block device on each target
-	  node that is to be used for the /data file system.
+	  This option sets the name of the block device on each
+	  target node that is to be used for the /data file system.
+
+config TERRAFORM_AZURE_SPARSE_VOLUME_DEVICE_FILE_NAME
+	string "Sparse volume's device file name"
+	output yaml
+	default "/dev/disk/azure/scsi1/lun1"
+	help
+	  This option sets the name of the block device on each
+	  target node that can be used for the fstests sparse device
+	  tests.

terraform/gce/kconfigs/Kconfig.storage

@@ -206,6 +206,18 @@ config TERRAFORM_GCE_DISK_THROUGHPUT
 	depends on TERRAFORM_GCE_DISK_NEEDS_THROUGHPUT
 
 config TERRAFORM_GCE_DATA_VOLUME_DEVICE_FILE_NAME
-	string
+	string "Data volume's device file name"
 	output yaml
 	default "/dev/disk/by-id/google-persistent-disk-1"
+	help
+	  This option sets the name of the block device on each
+	  target node that is to be used for the /data file system.
+
+config TERRAFORM_GCE_SPARSE_VOLUME_DEVICE_FILE_NAME
+	string "Sparse volume's device file name"
+	output yaml
+	default "/dev/disk/by-id/google-persistent-disk-2"
+	help
+	  This option sets the name of the block device on each
+	  target node that can be used for the fstests sparse device
+	  tests.

terraform/oci/kconfigs/Kconfig.storage

@@ -259,11 +259,14 @@ config TERRAFORM_OCI_DATA_VOLUME_DEVICE_FILE_NAME
 	output yaml
 	default "/dev/oracleoci/oraclevdb"
 	help
-	  Data volume's device file name
+	  This option sets the name of the block device on each
+	  target node that is to be used for the /data file system.
 
 config TERRAFORM_OCI_SPARSE_VOLUME_DEVICE_FILE_NAME
 	string "Sparse volume's device file name"
 	output yaml
 	default "/dev/oracleoci/oraclevdc"
 	help
-	  Sparse volume's device file name
+	  This option sets the name of the block device on each
+	  target node that can be used for the fstests sparse device
+	  tests.