Skip to content

Commit 1ce321a

Browse files
LiBinSHAHari Prasath Gujulan Elango
authored andcommitted
driver:dram: fix some dram configuration issues
Fix ZPROG[7:0] Impedance Divide Ratio, the value is 13 for 34Ohms. Fix DDR3 driver impedance value in KCONFIG, it support 34 and 40 ohms only. To be on the safe side, the AS4C256M16D3LC-10BIN should be configured as an 1866M, even though the 1600K works, but the risk is that there is a difference in tRP and tRCD timing between the 1600K and the 1866M. Set the speed bin to 1866 instead of 1333 for MT52L256M32D1PF_107 for performace. Signed-off-by: Li Bin <bin.li@microchip.com> Signed-off-by: Hari Prasath Gujulan Elango <hari.prasathge@microchip.com>
1 parent f3538d0 commit 1ce321a

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

Kconfig

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -577,10 +577,10 @@ config DDR_DRIVER_IMPEDANCE
577577
default 40 if DDR_MT47H128M16RT_25E_C
578578
default 48 if DDR_IS43LD16128B_25BLI
579579
default 48 if DDR_MT52L256M32D1PF_107
580-
default 48 if DDR_MT41K128M16JT_125
581-
default 48 if DDR_W631GU6NB
582-
default 48 if DDR_W632GU6NB12I
583-
default 48 if DDR_AS4C512M16D3LA_10BIN
580+
default 40 if DDR_MT41K128M16JT_125
581+
default 40 if DDR_W631GU6NB
582+
default 40 if DDR_W632GU6NB12I
583+
default 40 if DDR_AS4C512M16D3LA_10BIN
584584
default 40 if DDR_AS4C128M16D2A_25BAN
585585
default 40 if DDR_EM68D16CBQC_18IH
586586
default 48 if DDR_W97AH6NBVA1K
@@ -602,7 +602,7 @@ config DDR_ODT_IMPEDANCE
602602
default 50 if DDR_EM68D16CBQC_18IH
603603
default 0 if DDR_IS43LD16128B_25BLI
604604
default 0 if DDR_W97AH6NBVA1K
605-
default 120 if DDR_MT52L256M32D1PF_107
605+
default 60 if DDR_MT52L256M32D1PF_107
606606
default 0 if DDR_SET_BY_JEDEC || DDR_SET_BY_TIMING
607607
depends on UMCTL2
608608
help

driver/driver_cpp.mk

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ ifeq ($(CONFIG_DDR_AS4C256M16D3LC_12BCNTR), y)
9191
CPPFLAGS += -DCONFIG_DDR3 -DCONFIG_DDR3_SPEED_BIN_1600K -DCONFIG_DDR_4_GBIT -DCONFIG_DBW_16
9292
endif
9393
ifeq ($(CONFIG_DDR_AS4C512M16D3LA_10BIN), y)
94-
CPPFLAGS += -DCONFIG_DDR3 -DCONFIG_DDR3_SPEED_BIN_1600K -DCONFIG_DDR_8_GBIT -DCONFIG_DBW_16
94+
CPPFLAGS += -DCONFIG_DDR3 -DCONFIG_DDR3_SPEED_BIN_1866M -DCONFIG_DDR_8_GBIT -DCONFIG_DBW_16
9595
endif
9696
ifeq ($(CONFIG_DDR_W632GU6NB12I), y)
9797
CPPFLAGS += -DCONFIG_DDR3 -DCONFIG_DDR3_SPEED_BIN_1600K -DCONFIG_DDR_2_GBIT
@@ -106,7 +106,7 @@ ifeq ($(CONFIG_DDR_IS43LD16128B_25BLI), y)
106106
CPPFLAGS += -DCONFIG_LPDDR2 -DCONFIG_LPDDR2_S4 -DCONFIG_LPDDR2_SPEED_800 -DCONFIG_DDR_2_GBIT -DCONFIG_DBW_16
107107
endif
108108
ifeq ($(CONFIG_DDR_MT52L256M32D1PF_107), y)
109-
CPPFLAGS += -DCONFIG_LPDDR3 -DCONFIG_LPDDR3_SPEED_1333 -DCONFIG_DDR_8_GBIT -DCONFIG_DBW_32
109+
CPPFLAGS += -DCONFIG_LPDDR3 -DCONFIG_LPDDR3_SPEED_1866 -DCONFIG_DDR_8_GBIT -DCONFIG_DBW_32
110110
endif
111111
ifeq ($(CONFIG_DDR_EDB5432BEBH_1DAAT_F_D),y)
112112
CPPFLAGS += -DCONFIG_LPDDR2 -DCONFIG_LPDDR2_S4 -DCONFIG_LPDDR2_SPEED_800 -DCONFIG_DDR_512_MBIT -DCONFIG_DBW_16

include/dram_helpers.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@
253253
#define T_ZQ_RESET_NOP 0
254254
#define WLTPHY WL
255255
#define RLTPHY RL
256-
#define ZPROG_OUTPUT ((CONFIG_DDR_DRIVER_IMPEDANCE == 40) ? 11 : 12)
256+
#define ZPROG_OUTPUT ((CONFIG_DDR_DRIVER_IMPEDANCE == 40) ? 11 : 13)
257257
#define ZPROG_ODT ((CONFIG_DDR_ODT_IMPEDANCE == 120) ? 2 : (CONFIG_DDR_ODT_IMPEDANCE == 60) ? 6 : 9)
258258

259259
#elif defined(CONFIG_LPDDR2)

0 commit comments

Comments
 (0)