python 3.8 comp

Author: Goldziher

.github/workflows/ci.yaml

@@ -26,13 +26,17 @@ jobs:
         run: pre-commit run --show-diff-on-failure --color=always --all-files
   pyton_tests:
     runs-on: ubuntu-latest
+    strategy:
+      fail-fast: true
+      matrix:
+        python-version: ["3.8", "3.9", "3.10", "3.11"]
     steps:
       - name: Checkout repository
         uses: actions/checkout@v3
-      - name: Setup Python 3.11
+      - name: Setup Python ${{ matrix.python-version }}
         uses: actions/setup-python@v4
         with:
-          python-version: "3.11"
+          python-version: ${{ matrix.python-version }}
       - name: Install Poetry
         uses: snok/install-poetry@v1
         with:
@@ -44,7 +48,7 @@ jobs:
         uses: actions/cache@v3
         with:
           path: .venv
-          key: v1-venv-${{ runner.os }}-3.11-${{ hashFiles('**/poetry.lock') }}
+          key: v1-venv-${{ runner.os }}-${{ matrix.python-version }}-${{ hashFiles('**/poetry.lock') }}
       - name: Install Python Dependencies
         run: poetry install --no-interaction --no-root
       - name: Set pythonpath

tests/test_parse_qsl.py

@@ -1,3 +1,4 @@
+from typing import List, Tuple
 from urllib.parse import parse_qsl as stdlib_parse_qsl
 from urllib.parse import urlencode
 
@@ -34,7 +35,7 @@
         ("a=a+b;b=b+c", [("a", "a b;b=b c")]),
     ],
 )
-def test_parse_qsl_standard_separator(qs: str, expected: list[tuple[str, str]]) -> None:
+def test_parse_qsl_standard_separator(qs: str, expected: List[Tuple[str, str]]) -> None:
     result = fast_parse_qsl(qs.encode(), "&")
     assert result == stdlib_parse_qsl(qs, keep_blank_values=True) == expected
 
@@ -54,7 +55,7 @@ def test_parse_qsl_standard_separator(qs: str, expected: list[tuple[str, str]])
         ("a=1;a=2", [("a", "1"), ("a", "2")]),
     ],
 )
-def test_parse_qsl_semicolon_separator(qs: str, expected: list[tuple[str, str]]) -> None:
+def test_parse_qsl_semicolon_separator(qs: str, expected: List[Tuple[str, str]]) -> None:
     result = fast_parse_qsl(qs.encode(), ";")
     assert result == stdlib_parse_qsl(qs, separator=";", keep_blank_values=True) == expected
 
@@ -68,7 +69,7 @@ def test_parse_qsl_semicolon_separator(qs: str, expected: list[tuple[str, str]])
         (("first", "a@A&.ac"), ("second", "aaa")),
     ),
 )
-def test_query_parsing_of_escaped_values(values: tuple[tuple[str, str], tuple[str, str]]) -> None:
+def test_query_parsing_of_escaped_values(values: Tuple[Tuple[str, str], Tuple[str, str]]) -> None:
     url_encoded = urlencode(values)
     assert fast_parse_qsl(url_encoded.encode(), "&") == list(values)