refactor: update DispatcherTest

Author: butschster

tests/Unit/DispatcherTest.php

@@ -28,9 +28,14 @@ class DispatcherTest extends TestCase
     public function testConstructorRegistersRoutes(): void
     {
         $routes = [
-            'test/method' => $this->mockRoute,
+            $this->mockRoute,
         ];
 
+        $this->mockRoute
+            ->expects($this->once())
+            ->method('getMethods')
+            ->willReturn(['test/method']);
+
         $this->routesFactory
             ->expects($this->once())
             ->method('create')
@@ -59,7 +64,12 @@ public function testHandleRequestWithExistingRoute(): void
             ->with($request, $this->context)
             ->willReturn($expectedResult);
 
-        $routes = ['test/method' => $this->mockRoute];
+        $this->mockRoute
+            ->expects($this->once())
+            ->method('getMethods')
+            ->willReturn(['test/method']);
+
+        $routes = [$this->mockRoute];
         $this->routesFactory
             ->method('create')
             ->willReturn($routes);
@@ -84,7 +94,13 @@ public function testHandleRequestWithNonExistingRoute(): void
             params: [],
         );
 
-        $routes = ['test/method' => $this->mockRoute];
+        $routes = [$this->mockRoute];
+
+        $this->mockRoute
+            ->expects($this->once())
+            ->method('getMethods')
+            ->willReturn(['test/method']);
+
         $this->routesFactory
             ->method('create')
             ->willReturn($routes);
@@ -122,7 +138,12 @@ public function testHandleRequestLogsRequestDetails(): void
             ->method('handleRequest')
             ->willReturn($expectedResult);
 
-        $routes = ['test/method' => $this->mockRoute];
+        $this->mockRoute
+            ->expects($this->once())
+            ->method('getMethods')
+            ->willReturn(['test/method']);
+
+        $routes = [$this->mockRoute];
         $this->routesFactory
             ->method('create')
             ->willReturn($routes);
@@ -149,7 +170,12 @@ public function testHandleNotificationWithExistingRoute(): void
             ->method('handleNotification')
             ->with($notification, $this->context);
 
-        $routes = ['test/notification' => $this->mockRoute];
+        $this->mockRoute
+            ->expects($this->once())
+            ->method('getMethods')
+            ->willReturn(['test/notification']);
+
+        $routes = [$this->mockRoute];
         $this->routesFactory
             ->method('create')
             ->willReturn($routes);
@@ -171,7 +197,13 @@ public function testHandleNotificationWithNonExistingRoute(): void
             params: [],
         );
 
-        $routes = ['test/notification' => $this->mockRoute];
+        $routes = [$this->mockRoute];
+
+        $this->mockRoute
+            ->expects($this->once())
+            ->method('getMethods')
+            ->willReturn(['test/notification']);
+
         $this->routesFactory
             ->method('create')
             ->willReturn($routes);
@@ -200,7 +232,12 @@ public function testHandleNotificationDoesNotCallRouteWhenNotFound(): void
             ->expects($this->never())
             ->method('handleNotification');
 
-        $routes = ['test/notification' => $this->mockRoute];
+        $this->mockRoute
+            ->expects($this->once())
+            ->method('getMethods')
+            ->willReturn(['test/notification']);
+
+        $routes = [$this->mockRoute];
         $this->routesFactory
             ->method('create')
             ->willReturn($routes);
@@ -220,7 +257,12 @@ public function testHandleNotificationLogsNotificationDetails(): void
         $this->mockRoute
             ->method('handleNotification');
 
-        $routes = ['test/notification' => $this->mockRoute];
+        $this->mockRoute
+            ->expects($this->once())
+            ->method('getMethods')
+            ->willReturn(['test/notification']);
+
+        $routes = [$this->mockRoute];
         $this->routesFactory
             ->method('create')
             ->willReturn($routes);
@@ -238,17 +280,12 @@ public function testMultipleRoutesRegistration(): void
         $route1 = $this->createMock(RouteInterface::class);
         $route2 = $this->createMock(RouteInterface::class);
 
-        $routes = [
-            'method/one' => $route1,
-            'method/two' => $route2,
-        ];
+        $routes = [$route1, $route2];
 
         $this->routesFactory
             ->method('create')
             ->willReturn($routes);
 
-        $dispatcher = new Dispatcher($this->logger, $this->routesFactory);
-
         // Test first route
         $request1 = new Request('2.0', 1, 'method/one', []);
         $result1 = $this->createMock(Result::class);
@@ -259,8 +296,10 @@ public function testMultipleRoutesRegistration(): void
             ->with($request1, $this->context)
             ->willReturn($result1);
 
-        $actualResult1 = $dispatcher->handleRequest($request1, $this->context);
-        $this->assertSame($result1, $actualResult1);
+        $route1
+            ->expects($this->once())
+            ->method('getMethods')
+            ->willReturn(['method/one']);
 
         // Test second route
         $request2 = new Request('2.0', 2, 'method/two', []);
@@ -272,6 +311,16 @@ public function testMultipleRoutesRegistration(): void
             ->with($request2, $this->context)
             ->willReturn($result2);
 
+        $route2
+            ->expects($this->once())
+            ->method('getMethods')
+            ->willReturn(['method/two']);
+
+        $dispatcher = new Dispatcher($this->logger, $this->routesFactory);
+
+        $actualResult1 = $dispatcher->handleRequest($request1, $this->context);
+        $this->assertSame($result1, $actualResult1);
+
         $actualResult2 = $dispatcher->handleRequest($request2, $this->context);
         $this->assertSame($result2, $actualResult2);
     }
@@ -302,7 +351,12 @@ public function testRouteExceptionPropagation(): void
             ->method('handleRequest')
             ->willThrowException($customException);
 
-        $routes = ['test/method' => $this->mockRoute];
+        $this->mockRoute
+            ->expects($this->once())
+            ->method('getMethods')
+            ->willReturn(['test/method']);
+
+        $routes = [$this->mockRoute];
         $this->routesFactory
             ->method('create')
             ->willReturn($routes);
@@ -325,7 +379,12 @@ public function testNotificationRouteExceptionHandling(): void
             ->method('handleNotification')
             ->willThrowException($customException);
 
-        $routes = ['test/notification' => $this->mockRoute];
+        $this->mockRoute
+            ->expects($this->once())
+            ->method('getMethods')
+            ->willReturn(['test/notification']);
+
+        $routes = [$this->mockRoute];
         $this->routesFactory
             ->method('create')
             ->willReturn($routes);
@@ -370,7 +429,12 @@ public function testHandleRequestWithNullParams(): void
             ->with($request, $this->context)
             ->willReturn($expectedResult);
 
-        $routes = ['test/method' => $this->mockRoute];
+        $this->mockRoute
+            ->expects($this->once())
+            ->method('getMethods')
+            ->willReturn(['test/method']);
+
+        $routes = [$this->mockRoute];
         $this->routesFactory
             ->method('create')
             ->willReturn($routes);
@@ -398,7 +462,12 @@ public function testHandleNotificationWithNullParams(): void
             ->method('handleNotification')
             ->with($notification, $this->context);
 
-        $routes = ['test/notification' => $this->mockRoute];
+        $this->mockRoute
+            ->expects($this->once())
+            ->method('getMethods')
+            ->willReturn(['test/notification']);
+
+        $routes = [$this->mockRoute];
         $this->routesFactory
             ->method('create')
             ->willReturn($routes);