style(php-cs-fixer): fix coding standards

Author: github-actions

tests/Unit/Session/ArraySessionHandlerTest.php

@@ -5,7 +5,6 @@
 namespace Mcp\Server\Tests\Unit\Session;
 
 use Mcp\Server\Session\ArraySessionHandler;
-use Mockery;
 use PHPUnit\Framework\TestCase;
 use Psr\Clock\ClockInterface;
 
@@ -14,17 +13,6 @@ final class ArraySessionHandlerTest extends TestCase
     private ClockInterface $clock;
     private ArraySessionHandler $handler;
 
-    protected function setUp(): void
-    {
-        $this->clock = Mockery::mock(ClockInterface::class);
-        $this->handler = new ArraySessionHandler(ttl: 3600, clock: $this->clock);
-    }
-
-    protected function tearDown(): void
-    {
-        Mockery::close();
-    }
-
     public function test_read_returns_false_when_session_not_exists(): void
     {
         $result = $this->handler->read('non-existent-id');
@@ -178,4 +166,15 @@ public function test_constructor_with_custom_ttl(): void
 
         $this->assertEquals(7200, $handler->ttl);
     }
+
+    protected function setUp(): void
+    {
+        $this->clock = \Mockery::mock(ClockInterface::class);
+        $this->handler = new ArraySessionHandler(ttl: 3600, clock: $this->clock);
+    }
+
+    protected function tearDown(): void
+    {
+        \Mockery::close();
+    }
 }

tests/Unit/Session/CacheSessionHandlerTest.php

@@ -5,7 +5,6 @@
 namespace Mcp\Server\Tests\Unit\Session;
 
 use Mcp\Server\Session\CacheSessionHandler;
-use Mockery;
 use PHPUnit\Framework\TestCase;
 use Psr\Clock\ClockInterface;
 use Psr\SimpleCache\CacheInterface;
@@ -16,25 +15,6 @@ final class CacheSessionHandlerTest extends TestCase
     private ClockInterface $clock;
     private CacheSessionHandler $handler;
 
-    protected function setUp(): void
-    {
-        $this->cache = Mockery::mock(CacheInterface::class);
-        $this->clock = Mockery::mock(ClockInterface::class);
-        
-        // Mock the initial session index retrieval in constructor
-        $this->cache->shouldReceive('get')
-            ->with('mcp_session_index', [])
-            ->andReturn([])
-            ->once();
-            
-        $this->handler = new CacheSessionHandler($this->cache, ttl: 3600, clock: $this->clock);
-    }
-
-    protected function tearDown(): void
-    {
-        Mockery::close();
-    }
-
     public function test_read_returns_false_when_session_not_exists(): void
     {
         $this->cache->shouldReceive('get')->with('non-existent-id', false)->andReturn(false);
@@ -47,7 +27,7 @@ public function test_read_returns_false_when_session_not_exists(): void
     public function test_read_removes_expired_session_from_index(): void
     {
         $sessionId = 'expired-session';
-        
+
         // Session exists in cache but not in index
         $this->cache->shouldReceive('get')->with($sessionId, false)->andReturn(false);
         $this->cache->shouldReceive('set')->with('mcp_session_index', [])->andReturn(true);
@@ -209,7 +189,7 @@ public function test_gc_returns_empty_array_when_no_expired_sessions(): void
 
     public function test_constructor_with_default_ttl(): void
     {
-        $cache = Mockery::mock(CacheInterface::class);
+        $cache = \Mockery::mock(CacheInterface::class);
         $cache->shouldReceive('get')->with('mcp_session_index', [])->andReturn([]);
 
         $handler = new CacheSessionHandler($cache);
@@ -219,7 +199,7 @@ public function test_constructor_with_default_ttl(): void
 
     public function test_constructor_with_custom_ttl(): void
     {
-        $cache = Mockery::mock(CacheInterface::class);
+        $cache = \Mockery::mock(CacheInterface::class);
         $cache->shouldReceive('get')->with('mcp_session_index', [])->andReturn([]);
 
         $handler = new CacheSessionHandler($cache, ttl: 7200);
@@ -248,7 +228,7 @@ public function test_multiple_operations_maintain_index_consistency(): void
         $this->cache->shouldReceive('set')
             ->with('mcp_session_index', [
                 $sessionId1 => $currentTime->getTimestamp(),
-                $sessionId2 => $currentTime->getTimestamp()
+                $sessionId2 => $currentTime->getTimestamp(),
             ])
             ->andReturn(true);
         $this->cache->shouldReceive('set')->with($sessionId2, $sessionData2)->andReturn(true);
@@ -263,4 +243,23 @@ public function test_multiple_operations_maintain_index_consistency(): void
 
         $this->assertTrue($result);
     }
+
+    protected function setUp(): void
+    {
+        $this->cache = \Mockery::mock(CacheInterface::class);
+        $this->clock = \Mockery::mock(ClockInterface::class);
+
+        // Mock the initial session index retrieval in constructor
+        $this->cache->shouldReceive('get')
+            ->with('mcp_session_index', [])
+            ->andReturn([])
+            ->once();
+
+        $this->handler = new CacheSessionHandler($this->cache, ttl: 3600, clock: $this->clock);
+    }
+
+    protected function tearDown(): void
+    {
+        \Mockery::close();
+    }
 }

tests/Unit/Session/SessionIdGeneratorTest.php

@@ -6,17 +6,11 @@
 
 use Mcp\Server\Session\SessionIdGenerator;
 use PHPUnit\Framework\TestCase;
-use Random\RandomException;
 
 final class SessionIdGeneratorTest extends TestCase
 {
     private SessionIdGenerator $generator;
 
-    protected function setUp(): void
-    {
-        $this->generator = new SessionIdGenerator();
-    }
-
     public function test_generate_returns_string(): void
     {
         $sessionId = $this->generator->generate();
@@ -28,7 +22,7 @@ public function test_generate_returns_32_character_hex_string(): void
     {
         $sessionId = $this->generator->generate();
 
-        $this->assertEquals(32, strlen($sessionId));
+        $this->assertEquals(32, \strlen($sessionId));
         $this->assertMatchesRegularExpression('/^[a-f0-9]{32}$/', $sessionId);
     }
 
@@ -53,8 +47,8 @@ public function test_generate_uses_cryptographically_secure_randomness(): void
         $this->assertNotEquals($id1, $id2);
 
         // Check that the IDs have good entropy (not all the same character)
-        $this->assertNotEquals(str_repeat($id1[0], 32), $id1);
-        $this->assertNotEquals(str_repeat($id2[0], 32), $id2);
+        $this->assertNotEquals(\str_repeat($id1[0], 32), $id1);
+        $this->assertNotEquals(\str_repeat($id2[0], 32), $id2);
     }
 
     public function test_multiple_generators_produce_unique_ids(): void
@@ -83,18 +77,18 @@ public function test_generated_id_represents_16_bytes(): void
         $sessionId = $this->generator->generate();
 
         // Convert hex string back to binary to verify it represents 16 bytes
-        $binaryData = hex2bin($sessionId);
-        $this->assertEquals(16, strlen($binaryData));
+        $binaryData = \hex2bin($sessionId);
+        $this->assertEquals(16, \strlen($binaryData));
     }
 
     public function test_generated_ids_have_good_distribution(): void
     {
-        $charCounts = array_fill_keys(str_split('0123456789abcdef'), 0);
+        $charCounts = \array_fill_keys(\str_split('0123456789abcdef'), 0);
 
         // Generate many IDs and count character frequency
         for ($i = 0; $i < 100; $i++) {
             $sessionId = $this->generator->generate();
-            foreach (str_split($sessionId) as $char) {
+            foreach (\str_split($sessionId) as $char) {
                 $charCounts[$char]++;
             }
         }
@@ -105,11 +99,16 @@ public function test_generated_ids_have_good_distribution(): void
         }
 
         // Check that no character dominates (rough distribution check)
-        $totalChars = array_sum($charCounts);
+        $totalChars = \array_sum($charCounts);
         $expectedAverage = $totalChars / 16; // 16 hex characters
 
         foreach ($charCounts as $char => $count) {
             $this->assertLessThan($expectedAverage * 3, $count, "Character '{$char}' appears too frequently");
         }
     }
+
+    protected function setUp(): void
+    {
+        $this->generator = new SessionIdGenerator();
+    }
 }