migrate terraform-package from core to terraform-init (#104)

Author: alexrashed

terraform-init/README.md

@@ -13,7 +13,7 @@ LocalStack Extension for using Terraform files in [init hooks](https://docs.loca
 ## Usage
 
 * Start localstack with `EXTENSION_AUTO_INSTALL="localstack-extension-terraform-init"`
-* Optionally specify `TERRAFORM_VERSION=1.9.5` (currently defaults to 1.5.7) 
+* Optionally specify `TERRAFORM_VERSION=1.13.2` (currently defaults to 1.5.7)
 * Mount a `main.tf` file into `/etc/localstack/init/ready.d`
 
 When LocalStack starts up, it will install the extension, which in turn install `terraform` and `tflocal` into the container.

terraform-init/localstack_terraform_init/extension.py

@@ -1,15 +1,14 @@
 import logging
 import os
-from typing import List
 
 from localstack import config
 from localstack.extensions.api import Extension
-from localstack.packages import InstallTarget, Package, PackageInstaller
-from localstack.packages.core import PythonPackageInstaller
-from localstack.packages.terraform import terraform_package
+from localstack.packages import InstallTarget
 from localstack.runtime.init import ScriptRunner
 from localstack.utils.run import run
 
+from .packages import terraform_package, tflocal_package
+
 LOG = logging.getLogger(__name__)
 
 
@@ -23,25 +22,6 @@ def on_extension_load(self):
         )
 
 
-class TflocalPackage(Package):
-    def __init__(self, default_version: str = "0.18.2"):
-        super().__init__(name="terraform_local", default_version=default_version)
-
-    def _get_installer(self, version: str) -> PackageInstaller:
-        return TflocalPackageInstaller(version)
-
-    def get_versions(self) -> List[str]:
-        return [self.default_version]
-
-
-class TflocalPackageInstaller(PythonPackageInstaller):
-    def __init__(self, version: str):
-        super().__init__("terraform_local", version)
-
-
-tflocal_package = TflocalPackage()
-
-
 class TflocalScriptRunner(ScriptRunner):
     name = "tflocal"
 

terraform-init/localstack_terraform_init/packages.py

@@ -0,0 +1,66 @@
+import os
+import platform
+
+from localstack.packages import InstallTarget, Package, PackageInstaller
+from localstack.packages.core import (
+    ArchiveDownloadAndExtractInstaller,
+    PythonPackageInstaller,
+)
+from localstack.utils.files import chmod_r
+from localstack.utils.platform import get_arch
+
+TERRAFORM_VERSION = os.getenv("TERRAFORM_VERSION", "1.5.7")
+TERRAFORM_URL_TEMPLATE = "https://releases.hashicorp.com/terraform/{version}/terraform_{version}_{os}_{arch}.zip"
+TERRAFORM_CHECKSUM_URL_TEMPLATE = (
+    "https://releases.hashicorp.com/terraform/{version}/terraform_{version}_SHA256SUMS"
+)
+
+
+class TerraformPackage(Package["TerraformPackageInstaller"]):
+    def __init__(self) -> None:
+        super().__init__("Terraform", TERRAFORM_VERSION)
+
+    def get_versions(self) -> list[str]:
+        return [TERRAFORM_VERSION]
+
+    def _get_installer(self, version: str) -> "TerraformPackageInstaller":
+        return TerraformPackageInstaller("terraform", version)
+
+
+class TerraformPackageInstaller(ArchiveDownloadAndExtractInstaller):
+    def _get_install_marker_path(self, install_dir: str) -> str:
+        return os.path.join(install_dir, "terraform")
+
+    def _get_download_url(self) -> str:
+        system = platform.system().lower()
+        arch = get_arch()
+        return TERRAFORM_URL_TEMPLATE.format(
+            version=TERRAFORM_VERSION, os=system, arch=arch
+        )
+
+    def _install(self, target: InstallTarget) -> None:
+        super()._install(target)
+        chmod_r(self.get_executable_path(), 0o777)  # type: ignore[arg-type]
+
+    def _get_checksum_url(self) -> str | None:
+        return TERRAFORM_CHECKSUM_URL_TEMPLATE.format(version=TERRAFORM_VERSION)
+
+
+class TflocalPackage(Package):
+    def __init__(self, default_version: str = "0.24.1"):
+        super().__init__(name="terraform_local", default_version=default_version)
+
+    def _get_installer(self, version: str) -> PackageInstaller:
+        return TflocalPackageInstaller(version)
+
+    def get_versions(self) -> list[str]:
+        return [self.default_version]
+
+
+class TflocalPackageInstaller(PythonPackageInstaller):
+    def __init__(self, version: str):
+        super().__init__("terraform_local", version)
+
+
+tflocal_package = TflocalPackage()
+terraform_package = TerraformPackage()

terraform-init/setup.cfg

@@ -22,5 +22,5 @@ dev =
 [options.entry_points]
 localstack.extensions =
     localstack-terraform-init = localstack_terraform_init.extension:TflocalInitExtension
-localstack.init.runner=
+localstack.init.runner =
     tflocal = localstack_terraform_init.extension:TflocalScriptRunner