Solved code style issues

Author: alexcams

lib/logstash/filters/elasticsearch/client.rb

@@ -108,11 +108,9 @@ def setup_api_key(api_key)
       end
 
       def is_base64?(string)
-        begin
           string == Base64.strict_encode64(Base64.strict_decode64(string))
-        rescue ArgumentError
-          false
-        end
+      rescue ArgumentError
+        false
       end
 
       def get_transport_client_class

spec/filters/elasticsearch_spec.rb

@@ -4,7 +4,6 @@
 require "logstash/filters/elasticsearch"
 require "logstash/json"
 require "cabin"
-require "manticore"
 require "webrick"
 require "uri"
 
@@ -326,25 +325,30 @@ def wait_receive_request
 
       context "with ssl" do
         let(:config) { super().merge("ssl_enabled" => true) }
-        encoded_api_key = Base64.strict_encode64('foo:bar')
+        let(:encoded_api_key) { Base64.strict_encode64('foo:bar') }
 
-        scenarios = {
-          'with non-encoded api-key' => LogStash::Util::Password.new('foo:bar'),
-          'with encoded api-key' => LogStash::Util::Password.new(encoded_api_key)
-        }
+        shared_examples "a plugin that sets the ApiKey authorization header" do
+          it "correctly sets the Authorization header" do
+            plugin.register
+            client= plugin.send(:get_client).client
+            auth_header = extract_transport(client).options[:transport_options][:headers]['Authorization']
 
-        scenarios.each do |description, api_key_value|
-          context description do
-            let(:config) { super().merge('api_key' => api_key_value) }
+            expect(auth_header).to eql("ApiKey #{encoded_api_key}")
+          end
+        end
 
-            it "should set authorization" do
-              plugin.register
-              client= plugin.send(:get_client).client
-              auth_header = extract_transport(client).options[:transport_options][:headers]['Authorization']
+        context "with a non-encoded API key" do
+          let(:config) do
+            super().merge('api_key' => LogStash::Util::Password.new('foo:bar'))
+          end
+          it_behaves_like "a plugin that sets the ApiKey authorization header"
+        end
 
-              expect(auth_header).to eql "ApiKey #{encoded_api_key}"
-            end
+        context "with an encoded API key" do
+          let(:config) do
+            super().merge('api_key' => LogStash::Util::Password.new(encoded_api_key))
           end
+          it_behaves_like "a plugin that sets the ApiKey authorization header"
         end
 
         context 'user also set' do