Skip to content

Commit 96c23dd

Browse files
committed
noop: upcase and rename static immutable variable
1 parent f7967d5 commit 96c23dd

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/main/java/org/logstash/plugins/inputs/http/MessageProcessor.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,8 @@ public class MessageProcessor implements RejectableRunnable {
2525
private final String remoteAddress;
2626
private final IMessageHandler messageHandler;
2727
private final HttpResponseStatus responseStatus;
28-
private static final Charset charset = Charset.forName("UTF-8");
29-
3028

29+
private static final Charset UTF8_CHARSET = Charset.forName("UTF-8");
3130
private final static Logger LOGGER = LogManager.getLogger(MessageHandler.class);
3231

3332
MessageProcessor(ChannelHandlerContext ctx, FullHttpRequest req, String remoteAddress,
@@ -74,7 +73,7 @@ public void run() {
7473

7574
private FullHttpResponse processMessage() {
7675
final Map<String, String> formattedHeaders = formatHeaders(req.headers());
77-
final String body = req.content().toString(charset);
76+
final String body = req.content().toString(UTF8_CHARSET);
7877
if (messageHandler.onNewMessage(remoteAddress, formattedHeaders, body)) {
7978
return generateResponse(messageHandler.responseHeaders());
8079
} else {
@@ -107,7 +106,7 @@ private FullHttpResponse generateResponse(Map<String, String> stringHeaders) {
107106
response.headers().set(headers);
108107

109108
if (responseStatus != HttpResponseStatus.NO_CONTENT) {
110-
final ByteBuf payload = Unpooled.wrappedBuffer("ok".getBytes(charset));
109+
final ByteBuf payload = Unpooled.wrappedBuffer("ok".getBytes(UTF8_CHARSET));
111110
response.headers().set(HttpHeaderNames.CONTENT_LENGTH, payload.readableBytes());
112111
response.headers().set(HttpHeaderNames.CONTENT_TYPE, "text/plain");
113112
response.content().writeBytes(payload);

0 commit comments

Comments
 (0)