fix: Update Broadcasts to new design

Author: kirre-bylund

Runtime/Game/LootLockerSDKManager.cs

@@ -8381,7 +8381,7 @@ public static void MarkNotificationsAsRead(string[] NotificationIds, Action<Loot
 
         #region Broadcasts
         /// <summary>
-        /// List broadcasts for this game with default localisation and pagination settings
+        /// List broadcasts for this game with default localisation and limit
         /// </summary>
         /// <param name="onComplete">Delegate for handling the server response</param>
         /// <param name="forPlayerWithUlid">Optional : Execute the request for the specified player. If not supplied, the default player will be used.</param>
@@ -8397,7 +8397,7 @@ public static void ListTopBroadcasts(Action<LootLockerListBroadcastsResponse> on
         }
 
         /// <summary>
-        /// List broadcasts for this game with specified localisation and default pagination settings
+        /// List broadcasts for this game with specified localisation and default limit
         /// </summary>
         /// <param name="languages">Array of language codes to filter the broadcasts by. Language codes are typically ISO 639-1 codes (e.g. "en", "fr", "es") with regional variations (e.g. "en-US", "fr-FR"), but can also be custom defined by the game developer.</param>
         /// <param name="onComplete">Delegate for handling the server response</param>
@@ -8427,11 +8427,10 @@ public static void ListTopBroadcastsLocalized(string[] languages, Action<LootLoc
         /// List broadcasts for this game
         /// </summary>
         /// <param name="languages">Array of language codes to filter the broadcasts by. Language codes are typically ISO 639-1 codes (e.g. "en", "fr", "es") with regional variations (e.g. "en-US", "fr-FR"), but can also be custom defined by the game developer.</param>
-        /// <param name="per_page">Used for pagination, this is the number of broadcasts to retrieve per page.</param>
-        /// <param name="page">Used for pagination, this is the page number to retrieve.</param>
+        /// <param name="limit">Limit the number of broadcasts returned.</param>
         /// <param name="onComplete">Delegate for handling the server response</param>
         /// <param name="forPlayerWithUlid">Optional : Execute the request for the specified player. If not supplied, the default player will be used.</param>
-        public static void ListBroadcasts(string[] languages, int per_page, int page, Action<LootLockerListBroadcastsResponse> onComplete, string forPlayerWithUlid = null)
+        public static void ListBroadcasts(string[] languages, int limit, Action<LootLockerListBroadcastsResponse> onComplete, string forPlayerWithUlid = null)
         {
             if (!CheckInitialized(false, forPlayerWithUlid))
             {
@@ -8442,10 +8441,8 @@ public static void ListBroadcasts(string[] languages, int per_page, int page, Ac
             var endpoint = LootLockerEndPoints.ListBroadcasts.endPoint;
 
             var queryParams = new LootLocker.Utilities.HTTP.QueryParamaterBuilder();
-            if (per_page > 0)
-                queryParams.Add("per_page", per_page);
-            if (page > 0)
-                queryParams.Add("page", page);
+            if (limit > 0)
+                queryParams.Add("limit", limit);
 
             endpoint += queryParams.Build();
 

Runtime/Game/Requests/BroadcastRequest.cs

@@ -193,10 +193,6 @@ public class __LootLockerInternalListBroadcastsResponse : LootLockerResponse
         /// A list of cronologically ordered broadcasts
         /// </summary>
         public __LootLockerInternalBroadcast[] broadcasts { get; set; }
-        /// <summary>
-        /// Pagination information for the request
-        /// </summary>
-        public LootLockerExtendedPagination pagination { get; set; }
     };
 
     /// <summary>
@@ -208,10 +204,6 @@ public class LootLockerListBroadcastsResponse : LootLockerResponse
         /// A list of cronologically ordered broadcasts
         /// </summary>
         public LootLockerBroadcast[] broadcasts { get; set; }
-        /// <summary>
-        /// Pagination information for the request
-        /// </summary>
-        public LootLockerExtendedPagination pagination { get; set; }
 
         public LootLockerListBroadcastsResponse()
         {
@@ -232,7 +224,6 @@ public LootLockerListBroadcastsResponse(__LootLockerInternalListBroadcastsRespon
             EventId = internalResponse.EventId;
             errorData = internalResponse.errorData;
             text = internalResponse.text;
-            pagination = internalResponse.pagination;
 
             if (internalResponse.broadcasts == null || internalResponse.broadcasts.Length == 0)
             {

Runtime/Game/Utilities/LootLockerTimezoneConverter.cs

@@ -701,7 +701,7 @@ public static bool TryConvertStringToIanaTzString(string timezone, out string ia
             }
             else if (isValidWindowsTimezone(timezone))
             {
-                ianaTimezone = ConvertWindowsToIana(timezone);
+                ianaTimezone = ConvertWindowsToIanaTzString(timezone);
                 return true;
             }
             else
@@ -721,7 +721,7 @@ public static bool TryConvertStringToWindowsTzString(string timezone, out string
 
             else if (isValidIanaTimezone(timezone))
             {
-                windowsTimezone = ConvertIANAToWindows(timezone);
+                windowsTimezone = ConvertIANAToWindowsTzString(timezone);
                 return true;
             }
             else if (isValidWindowsTimezone(timezone))

Tests/LootLockerTests/PlayMode/BroadcastTests.cs

@@ -23,9 +23,6 @@ public void Broadcasts_DeserializingBroadcasts_PopulatesConvenienceResponseObjec
             // Then
             Assert.IsNotNull(broadcastResponse);
             Assert.IsNotEmpty(broadcastResponse.broadcasts);
-            Assert.IsNotNull(broadcastResponse.pagination);
-            Assert.AreEqual(1, broadcastResponse.pagination.total);
-            Assert.AreEqual(1, broadcastResponse.pagination.current_page);
             Assert.AreEqual(1, broadcastResponse.broadcasts.Length);
             Assert.AreEqual("01K4QGQTNHTXHM9ET5238NB4NF", broadcastResponse.broadcasts[0].id);
             Assert.AreEqual("Broadcast no 5", broadcastResponse.broadcasts[0].name);