Skip to content

Commit 8e08825

Browse files
committed
Making norun_tests env_types combinations robust
Earlier, we were looking for only specific permutations of norun_tests combinations. Now, it is more robust by using permutations. Signed-off-by: Narasimhan V <sim@linux.vnet.ibm.com>
1 parent d14a603 commit 8e08825

File tree

1 file changed

+12
-8
lines changed

1 file changed

+12
-8
lines changed

avocado-setup.py

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import argparse
2424
import configparser
2525
import binascii
26+
from itertools import permutations
2627
from shutil import copyfile
2728

2829
from lib.logger import logger_init
@@ -443,14 +444,17 @@ def parse_test_config(test_config_file, avocado_bin, enable_kvm):
443444
(env_ver, env_type, cmdpat) = helper.get_env_type(enable_kvm)
444445
norun_tests = []
445446
# Get common set of not needed tests
446-
env = 'norun_%s' % env_type
447-
dist = 'norun_%s' % helper.get_dist()[0]
448-
major = 'norun_%s' % env_ver.split('.')[0]
449-
minor = 'norun_%s' % env_ver
450-
minor_env = 'norun_%s_%s' % (env_ver, env_type)
451-
for section in [env, dist, major, minor, minor_env]:
452-
if NORUNTESTFILE.has_section(section):
453-
norun_tests.extend(NORUNTESTFILE.get(section, 'tests').split(','))
447+
dist = helper.get_dist()[0]
448+
major = env_ver.split('.')[0]
449+
minor = env_ver
450+
perm = []
451+
env_list = [env_type, dist, major, minor]
452+
for length in range(1, len(env_list) + 1):
453+
perm.extend(list(permutations(env_list, length)))
454+
perm = ['norun_%s' % '_'.join(per) for per in perm]
455+
for per in perm:
456+
if NORUNTESTFILE.has_section(per):
457+
norun_tests.extend(NORUNTESTFILE.get(per, 'tests').split(','))
454458
norun_tests = list(filter(None, norun_tests))
455459

456460
with open(test_config_file, 'r') as fp:

0 commit comments

Comments
 (0)