Skip to content

Commit a417339

Browse files
committed
Merge branch 'master' into info-plist
2 parents 56ea6b1 + 9f07e32 commit a417339

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

ResourceApp/ResourceAppTests/StringsTests.swift

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,14 @@ class StringsTests: XCTestCase {
3030

3131
func testCorrectValues() {
3232

33-
XCTAssertEqual(R.string.generic.precision1(12345.678), "one - 0,000,012,345.68")
33+
// Question: Why is this different between iOS 12 and 13?
34+
// "precision1" = "one - %012.2f";
35+
if #available(iOS 13, *) {
36+
XCTAssertEqual(R.string.generic.precision1(12345.678), "one - 12,345.68")
37+
} else {
38+
XCTAssertEqual(R.string.generic.precision1(12345.678), "one - 0,000,012,345.68")
39+
}
40+
3441
XCTAssertEqual(R.string.generic.precision2(12345.678), "two - 12,345.68")
3542
XCTAssertEqual(R.string.generic.precision3(12345.678), "three - 12,345.6780")
3643
XCTAssertEqual(R.string.generic.precision4(12345.678), "four - 12,345.68")

Sources/RswiftCore/Generators/StringsStructGenerator.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ struct StringsStructGenerator: ExternalOnlyStructGenerator {
258258
}
259259
260260
guard let (_, bundle) = localeBundle(tableName: "\(values.tableName)", preferredLanguages: preferredLanguages) else {
261-
return "\(values.key)"
261+
return "\(values.key.escapedStringLiteral)"
262262
}
263263
264264
return \(values.swiftCode(bundle: "bundle"))

0 commit comments

Comments
 (0)