Simplify logging configuration and cleanup unused code.

Removed redundant logging configuration logic and updated `logback.xml` to use environment variable defaults. Eliminated unused methods and test cases to streamline the `DockerMcpServer` implementation.

Author: makbn

src/main/java/io/github/makbn/mcp/mediator/docker/server/DockerMcpServer.java

@@ -19,12 +19,12 @@ public class DockerMcpServer {
     private static final String DOCKER_MCP_SERVER_VER = "1.0.0.0";
     private static final String DEFAULT_DOCKER_HOST = "unix:///var/run/docker.sock";
     private static final int DEFAULT_MAX_CONNECTIONS = 100;
+    public static final String HEADER = "'DOCKER_MCP_LOG_FILE' and 'DOCKER_MCP_LOG_LEVEL' can be set as env variables to modify logging config";
 
     public static void main(String[] args) {
         Options options = buildOptions();
         CommandLine cmd = parseOptions(args, options);
         try {
-            configureLogging(cmd);
             String dockerHost = cmd.getOptionValue("docker-host", DEFAULT_DOCKER_HOST);
             String serverName = cmd.getOptionValue("server-name", DOCKER_MCP_SERVER);
             String serverVersion = cmd.getOptionValue("server-version", DOCKER_MCP_SERVER_VER);
@@ -53,25 +53,6 @@ public static void main(String[] args) {
         }
     }
 
-    private static void configureLogging(CommandLine cmd) {
-        System.setProperty("DOCKER_MCP_LOG_FILE", cmd.getOptionValue("log-file", "logs/mcp_docker_server.log"));
-        System.setProperty("DOCKER_MCP_LOG_LEVEL", cmd.getOptionValue("log-level", "DEBUG"));
-    }
-
-    private static DockerClient intitializeDockerClient() {
-        DockerClientConfig config = DefaultDockerClientConfig.createDefaultConfigBuilder()
-                .withDockerHost("unix:///var/run/docker.sock")
-                .build();
-
-        DockerHttpClient client = new ApacheDockerHttpClient.Builder()
-                .dockerHost(config.getDockerHost())
-                .sslConfig(config.getSSLConfig())
-                .maxConnections(100)
-                .build();
-
-        return DockerClientImpl.getInstance(config, client);
-    }
-
     private static DockerClient initializeDockerClient(String dockerHost, int maxConnections, boolean tlsVerify, String certPath, String dockerConfig) {
         DefaultDockerClientConfig.Builder builder = DefaultDockerClientConfig.createDefaultConfigBuilder()
                 .withDockerHost(dockerHost);
@@ -132,7 +113,7 @@ private static CommandLine parseOptions(String[] args, Options options) {
 
     private static void printHelp(Options options) {
         HelpFormatter formatter = new HelpFormatter();
-        formatter.printHelp("DockerMcpServer", options);
+        formatter.printHelp("java -jar [SERVER_JAR_FILE] ", HEADER, options, "");
     }
 
 }

src/main/resources/logback.xml

@@ -1,17 +1,15 @@
 <configuration debug="false">
     <statusListener class="ch.qos.logback.core.status.NopStatusListener"/>
-    <property name="DOCKER_MCP_LOG_FILE" value="logs/docker_mcp_server.log" />
-    <property name="DOCKER_MCP_LOG_LEVEL" value="DEBUG" />
 
     <!--No logging to the stdout while the server is running on stdio mode-->
     <appender name="FILE" class="ch.qos.logback.core.FileAppender">
-        <file>${DOCKER_MCP_LOG_FILE}</file>
+        <file>${DOCKER_MCP_LOG_FILE:-logs/docker_mcp_server.log}</file>
         <encoder>
             <pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} -%kvp- %msg%n</pattern>
         </encoder>
     </appender>
 
-    <root level="${DOCKER_MCP_LOG_LEVEL}">
-        <appender-ref ref="FILE" />
+    <root level="${DOCKER_MCP_LOG_LEVEL:-DEBUG}">
+        <appender-ref ref="FILE"/>
     </root>
 </configuration>

src/test/java/io/github/makbn/mediator/docker/handler/DockerClientServiceTest.java

@@ -1,22 +1,7 @@
 package io.github.makbn.mediator.docker.handler;
 
-import com.fasterxml.jackson.core.JsonProcessingException;
-import com.fasterxml.jackson.databind.ObjectMapper;
-import com.github.dockerjava.api.model.SwarmNodeSpec;
-import io.github.makbn.mcp.mediator.core.internal.McpMethodSchemaGenerator;
-import io.github.makbn.mcp.mediator.docker.internal.DockerClientService;
-import org.junit.jupiter.api.Test;
-
 class DockerClientServiceTest {
 
-    @Test
-    void testDockerClientService() throws NoSuchMethodException, JsonProcessingException {
-        String schema = McpMethodSchemaGenerator.of(new ObjectMapper())
-                .generateSchemaForMethod(DockerClientService.class.getMethod("updateSwarmNodeCmd", String.class, SwarmNodeSpec.class));
-
-        System.out.println(schema);
-    }
-
 }