Enable dask+cupy (cuda) implementation for (some) convolution methods, e.g. aspect #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I already used these implementations for a project of mine, and they seemed to work fine. However, I did not extensive testing or encountered edges yet. Should I try to enable dask + cupy for other functions as well? |
Contributor
@relativityhd thanks so much for the quick response. What you have here looks good and we'll need to get some test which can run that code path along with updating docs. I should have some time to help later and test on my local environment. I believe that this would be related to the old...but open issue here: #140 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #814
Fixes #140
Proposed Changes