Issue summary
In the README's setup section, it says:
or, in a single line:
pip install git+https://github.com/mapillary/seamseg.git
But, since setuptools.setup() does not include the install_requires argument, the projects dependencies do not get installed.
|
setuptools.setup( |
|
# Meta-data |
|
name="seamseg", |
|
author="Lorenzo Porzi", |
|
author_email="lorenzo@mapillary.com", |
|
description="Seamless Scene Segmentation for Pytorch", |
|
long_description=long_description, |
|
long_description_content_type="text/markdown", |
|
url="https://github.com/mapillary/seamseg", |
|
classifiers=[ |
|
"Programming Language :: Python :: 3", |
|
"Programming Language :: Python :: 3.4", |
|
"Programming Language :: Python :: 3.5", |
|
"Programming Language :: Python :: 3.6", |
|
"Programming Language :: Python :: 3.7", |
|
], |
|
|
|
# Versioning |
|
use_scm_version={"root": ".", "relative_to": __file__, "write_to": "seamseg/_version.py"}, |
|
|
|
# Requirements |
|
setup_requires=["setuptools_scm"], |
|
python_requires=">=3, <4", |
|
|
|
# Package description |
|
packages=[ |
|
"seamseg", |
|
"seamseg.algos", |
|
"seamseg.config", |
|
"seamseg.data", |
|
"seamseg.models", |
|
"seamseg.modules", |
|
"seamseg.modules.heads", |
|
"seamseg.utils", |
|
"seamseg.utils.bbx", |
|
"seamseg.utils.nms", |
|
"seamseg.utils.parallel", |
|
"seamseg.utils.roi_sampling", |
|
], |
|
ext_modules=[ |
|
make_extension("nms", "seamseg.utils"), |
|
make_extension("bbx", "seamseg.utils"), |
|
make_extension("roi_sampling", "seamseg.utils") |
|
], |
|
cmdclass={"build_ext": BuildExtension}, |
|
include_package_data=True, |
|
) |
The pip install one-liner ends in errors for me unless I install torch myself. And even when I do that, when I try to run the seamseg scripts, I hit errors because dependencies like umsgpack and inplace_abn are not installed.
Possible solution
Could we add something like this?
...
requirements = []
with open("requirements.txt") as f:
requirements = f.read().splitlines()
setuptools.setup(
...
# Requirements
setup_requires=["setuptools_scm"],
python_requires=">=3, <4",
install_requires=requirements,
...
)
Issue summary
In the README's setup section, it says:
But, since
setuptools.setup()does not include theinstall_requiresargument, the projects dependencies do not get installed.seamseg/setup.py
Lines 34 to 80 in 3d10aea
The
pip installone-liner ends in errors for me unless I installtorchmyself. And even when I do that, when I try to run theseamsegscripts, I hit errors because dependencies likeumsgpackandinplace_abnare not installed.Possible solution
Could we add something like this?