Improve type hinting

Author: markwalet

src/Adapters/FakeFeatureAdapter.php

@@ -11,13 +11,15 @@ class FakeFeatureAdapter implements FeatureAdapter
     /**
      * @var Change[]|array
      */
-    private $changes = [];
+    private array $changes = [];
 
     /**
+     * Set a lis of changes for the given path.
+     *
      * @param string $path
      * @param Feature $changes
      */
-    public function setChanges(string $path, Feature $changes)
+    public function setChanges(string $path, Feature $changes): void
     {
         $this->changes[$path] = $changes;
     }

src/Adapters/FakeReleaseAdapter.php

@@ -15,10 +15,10 @@ class FakeReleaseAdapter implements ReleaseAdapter
     /**
      * @var Release[][]|array
      */
-    private $releases = [];
+    private array $releases = [];
 
     /**
-     * A a release to the list.
+     * A release to the list.
      *
      * @param string $path
      * @param string $version

src/Adapters/XmlFeatureAdapter.php

@@ -3,6 +3,7 @@
 namespace MarkWalet\Changelog\Adapters;
 
 use DOMDocument;
+use Illuminate\Contracts\Filesystem\FileNotFoundException as FilesystemFileNotFoundException;
 use Illuminate\Filesystem\Filesystem;
 use MarkWalet\Changelog\Change;
 use MarkWalet\Changelog\Exceptions\FileNotFoundException;
@@ -14,7 +15,7 @@ class XmlFeatureAdapter implements FeatureAdapter
     /**
      * @var Filesystem
      */
-    private $filesystem;
+    private Filesystem $filesystem;
 
     /**
      * XmlFeatureAdapter constructor.
@@ -34,13 +35,13 @@ public function read(string $path): Feature
     {
         try {
             $content = $this->filesystem->get($path);
-        } catch (\Illuminate\Contracts\Filesystem\FileNotFoundException $e) {
+        } catch (FilesystemFileNotFoundException $e) {
             throw new FileNotFoundException($path);
         }
 
         $element = simplexml_load_string($content);
 
-        $feature = new Feature;
+        $feature = new Feature();
 
         foreach ($element->children() as $change) {
             $type = $change->attributes()['type'];

src/Adapters/XmlReleaseAdapter.php

@@ -17,7 +17,7 @@ class XmlReleaseAdapter implements ReleaseAdapter
     /**
      * @var XmlFeatureAdapter
      */
-    private $featureAdapter;
+    private XmlFeatureAdapter $featureAdapter;
 
     /**
      * XmlReleaseAdapter constructor.

src/ChangelogFormatterFactory.php

@@ -40,7 +40,7 @@ public function make(string $type): ChangelogFormatter
         $driver = Arr::pull($config, 'driver');
 
         if (Arr::has(class_parents($driver), ChangelogFormatter::class) === false) {
-            throw new InvalidArgumentException("The driver {$driver} is not a valid driver.");
+            throw new InvalidArgumentException("The driver $driver is not a valid driver.");
         }
 
         return new $driver($config);

src/Commands/ChangelogAddCommand.php

@@ -83,7 +83,7 @@ private function changelog(FeatureAdapter $adapter, string $path): Feature
      * @param GitDriver $gitState
      * @return string
      */
-    private function path(GitDriver $gitState)
+    private function path(GitDriver $gitState): string
     {
         return config('changelog.path')
             .DIRECTORY_SEPARATOR.'unreleased'