Fix #131

Author: neutralleiter

core/src/main/java/eu/bittrade/libs/steemj/SteemJ.java

@@ -287,7 +287,7 @@ public void broadcastBlock(SignedBlock signedBlock) throws SteemCommunicationExc
      *             <li>If the Server returned an error object.</li>
      *             </ul>
      */
-    public Boolean login(AccountName accountName, String password)
+    public boolean login(AccountName accountName, String password)
             throws SteemCommunicationException, SteemResponseException {
         return LoginApi.login(communicationHandler, accountName, password);
     }
@@ -1565,36 +1565,6 @@ public WitnessSchedule getWitnessSchedule() throws SteemCommunicationException,
         return communicationHandler.performRequest(requestObject, WitnessSchedule.class).get(0);
     }
 
-    /**
-     * Login under the use of the credentials which are stored in the config
-     * object.
-     * 
-     * <p>
-     * <b>Notice:</b> The login method is only needed to access protected apis.
-     * For some apis like the broadcast_api a call of this method with empty
-     * strings can be enough to access them.
-     * 
-     * @return true if the login was successful. False otherwise.
-     * @throws SteemCommunicationException
-     *             <ul>
-     *             <li>If the server was not able to answer the request in the
-     *             given time (see
-     *             {@link eu.bittrade.libs.steemj.configuration.SteemJConfig#setResponseTimeout(int)
-     *             setResponseTimeout}).</li>
-     *             <li>If there is a connection problem.</li>
-     *             </ul>
-     * @throws SteemResponseException
-     *             <ul>
-     *             <li>If the SteemJ is unable to transform the JSON response
-     *             into a Java object.</li>
-     *             <li>If the Server returned an error object.</li>
-     *             </ul>
-     */
-    public Boolean login() throws SteemCommunicationException, SteemResponseException {
-        return login(SteemJConfig.getInstance().getApiUsername(),
-                String.valueOf(SteemJConfig.getInstance().getApiPassword()));
-    }
-
     /**
      * Search for accounts.
      * 
@@ -1686,7 +1656,7 @@ public List<String> lookupWitnessAccounts(String pattern, int limit)
      *             <li>If the Server returned an error object.</li>
      *             </ul>
      */
-    public Boolean verifyAuthority(SignedTransaction signedTransaction)
+    public boolean verifyAuthority(SignedTransaction signedTransaction)
             throws SteemCommunicationException, SteemResponseException {
         JsonRPCRequest requestObject = new JsonRPCRequest();
         requestObject.setApiMethod(RequestMethods.VERIFY_AUTHORITY);

core/src/main/java/eu/bittrade/libs/steemj/apis/database/models/state/Comment.java

@@ -88,11 +88,11 @@ public class Comment {
     @JsonProperty("percent_steem_dollars")
     private short percentSteemDollars;
     @JsonProperty("allow_replies")
-    private Boolean allowReplies;
+    private boolean allowReplies;
     @JsonProperty("allow_votes")
-    private Boolean allowVotes;
+    private boolean allowVotes;
     @JsonProperty("allow_curation_rewards")
-    private Boolean allowCurationRewards;
+    private boolean allowCurationRewards;
     // TODO: Fix type
     // bip::vector< beneficiary_route_type, allocator< beneficiary_route_type >
     // > beneficiaries;
@@ -332,21 +332,21 @@ public short getPercentSteemDollars() {
     /**
      * @return the allowReplies
      */
-    public Boolean getAllowReplies() {
+    public boolean getAllowReplies() {
         return allowReplies;
     }
 
     /**
      * @return the allowVotes
      */
-    public Boolean getAllowVotes() {
+    public boolean getAllowVotes() {
         return allowVotes;
     }
 
     /**
      * @return the allowCurationRewards
      */
-    public Boolean getAllowCurationRewards() {
+    public boolean getAllowCurationRewards() {
         return allowCurationRewards;
     }
 

core/src/main/java/eu/bittrade/libs/steemj/apis/login/LoginApi.java

@@ -57,7 +57,7 @@ private LoginApi() {
      *             <li>If the Server returned an error object.</li>
      *             </ul>
      */
-    public static Boolean login(CommunicationHandler communicationHandler, AccountName accountName, String password)
+    public static boolean login(CommunicationHandler communicationHandler, AccountName accountName, String password)
             throws SteemCommunicationException, SteemResponseException {
         JsonRPCRequest requestObject = new JsonRPCRequest();
         requestObject.setApiMethod(RequestMethods.LOGIN);

core/src/main/java/eu/bittrade/libs/steemj/base/models/Config.java

@@ -11,7 +11,7 @@
  */
 public class Config {
     @JsonProperty("IS_TEST_NET")
-    private Boolean isTestNet;
+    private boolean isTestNet;
     /**
      * @deprecated Has been removed with HF 19. Depending on the version of the
      *             used Steem Node the value of this field may be null.
@@ -404,7 +404,7 @@ private Config() {
     /**
      * @return the isTestNet
      */
-    public Boolean getIsTestNet() {
+    public boolean getIsTestNet() {
         return isTestNet;
     }
 

core/src/main/java/eu/bittrade/libs/steemj/base/models/operations/DeclineVotingRightsOperation.java

@@ -26,7 +26,7 @@ public class DeclineVotingRightsOperation extends Operation {
     @JsonProperty("account")
     private AccountName account;
     @JsonProperty("decline")
-    private Boolean decline;
+    private boolean decline;
 
     /**
      * Create a new decline voting rights operation. Use this operation with
@@ -38,12 +38,12 @@ public class DeclineVotingRightsOperation extends Operation {
      *            {@link #setAccount(AccountName)}).
      * @param decline
      *            Define if the voting rights should be declined or not (see
-     *            {@link #setDecline(Boolean)}).
+     *            {@link #setDecline(boolean)}).
      * @throws InvalidParameterException
      *             If one of the arguments does not fulfill the requirements.
      */
     public DeclineVotingRightsOperation(@JsonProperty("account") AccountName account,
-            @JsonProperty("decline") Boolean decline) {
+            @JsonProperty("decline") boolean decline) {
         super(false);
 
         this.setAccount(account);
@@ -79,7 +79,7 @@ public void setAccount(AccountName account) {
      * @return The information if the {@link #getAccount() account} decline its
      *         voting rights or not.
      */
-    public Boolean getDecline() {
+    public boolean getDecline() {
         return decline;
     }
 
@@ -91,12 +91,8 @@ public Boolean getDecline() {
      *            The information if the {@link #getAccount() account} decline
      *            its voting rights or not.
      */
-    public void setDecline(Boolean decline) {
-        if (decline == null) {
-            this.decline = false;
-        } else {
-            this.decline = decline;
-        }
+    public void setDecline(boolean decline) {
+        this.decline = decline;
     }
 
     @Override

core/src/main/java/eu/bittrade/libs/steemj/base/models/operations/EscrowApproveOperation.java

@@ -27,7 +27,7 @@ public class EscrowApproveOperation extends AbstractEscrowOperation {
     @JsonProperty("who")
     private AccountName who;
     @JsonProperty("approve")
-    private Boolean approve;
+    private boolean approve;
 
     /**
      * Create a new escrow approve operation.
@@ -61,7 +61,7 @@ public class EscrowApproveOperation extends AbstractEscrowOperation {
     @JsonCreator
     public EscrowApproveOperation(@JsonProperty("from") AccountName from, @JsonProperty("to") AccountName to,
             @JsonProperty("agent") AccountName agent, @JsonProperty("escrow_id") long escrowId,
-            @JsonProperty("who") AccountName who, @JsonProperty("approve") Boolean approve) {
+            @JsonProperty("who") AccountName who, @JsonProperty("approve") boolean approve) {
         super(false);
 
         this.setFrom(from);
@@ -152,7 +152,7 @@ public void setWho(AccountName who) {
      * 
      * @return True if the operation has been approved or false if not.
      */
-    public Boolean getApprove() {
+    public boolean getApprove() {
         return approve;
     }
 

core/src/main/java/eu/bittrade/libs/steemj/base/models/operations/LimitOrderCreate2Operation.java

@@ -31,7 +31,7 @@ public class LimitOrderCreate2Operation extends AbstractLimitOrderOperation {
     @JsonProperty("amount_to_sell")
     private Asset amountToSell;
     @JsonProperty("fill_or_kill")
-    private Boolean fillOrKill;
+    private boolean fillOrKill;
     @JsonProperty("exchange_rate")
     private Price exchangeRate;
     @JsonProperty("expiration")
@@ -54,7 +54,7 @@ public class LimitOrderCreate2Operation extends AbstractLimitOrderOperation {
      *            The amount to sell (see {@link #setAmountToSell(Asset)}).
      * @param fillOrKill
      *            Define if this order is a "fillOrKill" order (see
-     *            {@link #setFillOrKill(Boolean)}).
+     *            {@link #setFillOrKill(boolean)}).
      * @param exchangeRate
      *            The exchange rate to set (see
      *            {@link #setExchangeRate(Price)}).
@@ -67,7 +67,7 @@ public class LimitOrderCreate2Operation extends AbstractLimitOrderOperation {
     @JsonCreator
     public LimitOrderCreate2Operation(@JsonProperty("owner") AccountName owner,
             @JsonProperty("orderid") UInteger orderId, @JsonProperty("amount_to_sell") Asset amountToSell,
-            @JsonProperty("fill_or_kill") Boolean fillOrKill, @JsonProperty("exchange_rate") Price exchangeRate,
+            @JsonProperty("fill_or_kill") boolean fillOrKill, @JsonProperty("exchange_rate") Price exchangeRate,
             @JsonProperty("expiration") TimePointSec expirationDate) {
         super(false);
 
@@ -81,7 +81,7 @@ public LimitOrderCreate2Operation(@JsonProperty("owner") AccountName owner,
 
     /**
      * Like
-     * {@link #LimitOrderCreate2Operation(AccountName, UInteger, Asset, Boolean, Price, TimePointSec)},
+     * {@link #LimitOrderCreate2Operation(AccountName, UInteger, Asset, boolean, Price, TimePointSec)},
      * but this constructor applies default values for the
      * <code>fillOrKill</code> and the <code>expirationDate</code> parameters.
      * The <code>fillOrKill</code> parameter is set to false and the
@@ -200,7 +200,7 @@ public void setAmountToSell(Asset amountToSell) {
      * @return <code>true</code> if this order was a fill or kill order,
      *         otherwise <code>false</code>.
      */
-    public Boolean getFillOrKill() {
+    public boolean getFillOrKill() {
         return fillOrKill;
     }
 
@@ -214,12 +214,8 @@ public Boolean getFillOrKill() {
      *            <code>true</code> if this order is a fill or kill order,
      *            otherwise <code>false</code>.
      */
-    public void setFillOrKill(Boolean fillOrKill) {
-        if (fillOrKill == null) {
-            this.fillOrKill = false;
-        } else {
-            this.fillOrKill = fillOrKill;
-        }
+    public void setFillOrKill(boolean fillOrKill) {
+        this.fillOrKill = fillOrKill;
     }
 
     /**

core/src/main/java/eu/bittrade/libs/steemj/base/models/operations/LimitOrderCreateOperation.java

@@ -31,7 +31,7 @@ public class LimitOrderCreateOperation extends AbstractLimitOrderOperation {
     @JsonProperty("min_to_receive")
     private Asset minToReceive;
     @JsonProperty("fill_or_kill")
-    private Boolean fillOrKill;
+    private boolean fillOrKill;
     @JsonProperty("expiration")
     private TimePointSec expirationDate;
 
@@ -50,7 +50,7 @@ public class LimitOrderCreateOperation extends AbstractLimitOrderOperation {
      *            {@link #setMinToReceive(Asset)}).
      * @param fillOrKill
      *            Define if this order is a fill or kill order (see
-     *            {@link #setFillOrKill(Boolean)}).
+     *            {@link #setFillOrKill(boolean)}).
      * @param expirationDate
      *            Define how long this order is valid (see
      *            {@link #setExpirationDate(TimePointSec)}).
@@ -59,7 +59,7 @@ public class LimitOrderCreateOperation extends AbstractLimitOrderOperation {
      */
     public LimitOrderCreateOperation(@JsonProperty("owner") AccountName owner,
             @JsonProperty("orderid") UInteger orderId, @JsonProperty("amount_to_sell") Asset amountToSell,
-            @JsonProperty("min_to_receive") Asset minToReceive, @JsonProperty("fill_or_kill") Boolean fillOrKill,
+            @JsonProperty("min_to_receive") Asset minToReceive, @JsonProperty("fill_or_kill") boolean fillOrKill,
             @JsonProperty("expiration") TimePointSec expirationDate) {
         super(false);
 
@@ -213,7 +213,7 @@ public void setMinToReceive(Asset minToReceive) {
      * @return <code>true</code> if this order was a fill or kill order,
      *         otherwise <code>false</code>.
      */
-    public Boolean getFillOrKill() {
+    public boolean getFillOrKill() {
         return fillOrKill;
     }
 
@@ -227,12 +227,8 @@ public Boolean getFillOrKill() {
      *            <code>true</code> if this order is a fill or kill order,
      *            otherwise <code>false</code>.
      */
-    public void setFillOrKill(Boolean fillOrKill) {
-        if (fillOrKill == null) {
-            this.fillOrKill = false;
-        } else {
-            this.fillOrKill = fillOrKill;
-        }
+    public void setFillOrKill(boolean fillOrKill) {
+        this.fillOrKill = fillOrKill;
     }
 
     /**

core/src/main/java/eu/bittrade/libs/steemj/base/models/operations/ProveAuthorityOperation.java

@@ -27,7 +27,7 @@ public class ProveAuthorityOperation extends Operation {
     @JsonProperty("challenged")
     private AccountName challenged;
     @JsonProperty("require_owner")
-    private Boolean requireOwner;
+    private boolean requireOwner;
 
     /**
      * Create a new prove authority operation.
@@ -43,7 +43,7 @@ public class ProveAuthorityOperation extends Operation {
      */
     @JsonCreator
     public ProveAuthorityOperation(@JsonProperty("challenged") AccountName challenged,
-            @JsonProperty("require_owner") Boolean requireOwner) {
+            @JsonProperty("require_owner") boolean requireOwner) {
         super(false);
 
         this.setChallenged(challenged);
@@ -93,7 +93,7 @@ public void setChallenged(AccountName challenged) {
      * @return <code>true</code> if the owner key should be used to sign this
      *         operation, or false, if the active key is sufficient.
      */
-    public Boolean getRequireOwner() {
+    public boolean getRequireOwner() {
         return requireOwner;
     }
 

core/src/main/java/eu/bittrade/libs/steemj/base/models/operations/SetWithdrawVestingRouteOperation.java

@@ -33,7 +33,7 @@ public class SetWithdrawVestingRouteOperation extends Operation {
     @JsonProperty("percent")
     private int percent;
     @JsonProperty("auto_vest")
-    private Boolean autoVest;
+    private boolean autoVest;
 
     /**
      * Create a new set withdraw vesting route operation.
@@ -62,7 +62,7 @@ public class SetWithdrawVestingRouteOperation extends Operation {
     @JsonCreator
     public SetWithdrawVestingRouteOperation(@JsonProperty("from_account") AccountName fromAccount,
             @JsonProperty("to_account") AccountName toAccount, @JsonProperty("percent") int percent,
-            @JsonProperty("auto_vest") Boolean autoVest) {
+            @JsonProperty("auto_vest") boolean autoVest) {
         super(false);
 
         this.setFromAccount(fromAccount);
@@ -73,7 +73,7 @@ public SetWithdrawVestingRouteOperation(@JsonProperty("from_account") AccountNam
 
     /**
      * Like
-     * {@link #SetWithdrawVestingRouteOperation(AccountName, AccountName, int, Boolean)},
+     * {@link #SetWithdrawVestingRouteOperation(AccountName, AccountName, int, boolean)},
      * but will automatically use the default values (<code>percent=0</code> and
      * <code>autoVest=false</code>).
      * 
@@ -87,7 +87,7 @@ public SetWithdrawVestingRouteOperation(@JsonProperty("from_account") AccountNam
      *             If one of the arguments does not fulfill the requirements.
      */
     public SetWithdrawVestingRouteOperation(AccountName fromAccount, AccountName toAccount) {
-        this(fromAccount, toAccount, 0, Boolean.FALSE);
+        this(fromAccount, toAccount, 0, false);
     }
 
     /**
@@ -164,7 +164,7 @@ public void setPercent(int percent) {
      * 
      * @return True if the funds should be reinvested or false if not.
      */
-    public Boolean getAutoVest() {
+    public boolean getAutoVest() {
         return autoVest;
     }