Skip to content

Commit 7428284

Browse files
(Text): remove label from the type props
becuase it's no longer listed as a classname within https://v1.lightningdesignsystem.com/utilities/text/#CSS-Class-Overview
1 parent d7449e2 commit 7428284

File tree

3 files changed

+11
-13
lines changed

3 files changed

+11
-13
lines changed

src/scripts/PageHeader.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,19 +31,19 @@ export type PageHeaderDetailLabelProps = TextProps;
3131
export const PageHeaderDetailLabel: FC<PageHeaderDetailLabelProps> = ({
3232
children,
3333
...props
34-
}) =>
35-
typeof children === 'string' ? (
34+
}) => {
35+
return (
3636
<Text
37+
tag={typeof children !== 'string' ? 'div' : undefined}
3738
category='title'
3839
truncate
3940
className='slds-m-bottom_xx-small'
4041
{...props}
4142
>
4243
{children}
4344
</Text>
44-
) : (
45-
<>{children}</>
4645
);
46+
};
4747

4848
/**
4949
*

src/scripts/Text.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import classnames from 'classnames';
77
export type TextProps = {
88
tag?: keyof ReactHTML;
99
category?: 'body' | 'heading' | 'title';
10-
type?: 'small' | 'regular' | 'medium' | 'large' | 'caps' | 'label';
10+
type?: 'small' | 'regular' | 'medium' | 'large' | 'caps';
1111
align?: 'left' | 'center' | 'right';
1212
truncate?: boolean;
1313
section?: boolean;

stories/PageHeader.stories.tsx

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -97,14 +97,12 @@ export const RecordHome: ComponentStoryObj<typeof PageHeader> = {
9797
</PageHeaderDetailItem>
9898
<PageHeaderDetailItem>
9999
<PageHeaderDetailLabel>
100-
<Text tag='div' category='heading' type='label'>
101-
FIELD 2 (3)
102-
<DropdownButton type='icon-bare' iconSize='small' icon='down'>
103-
<MenuItem>Menu Item #1</MenuItem>
104-
<MenuItem>Menu Item #2</MenuItem>
105-
<MenuItem>Menu Item #3</MenuItem>
106-
</DropdownButton>
107-
</Text>
100+
FIELD 2 (3)
101+
<DropdownButton type='icon-bare' iconSize='small' icon='down'>
102+
<MenuItem>Menu Item #1</MenuItem>
103+
<MenuItem>Menu Item #2</MenuItem>
104+
<MenuItem>Menu Item #3</MenuItem>
105+
</DropdownButton>
108106
</PageHeaderDetailLabel>
109107
<PageHeaderDetailBody>
110108
<Text category='body' type='regular' title='Multiple Values'>

0 commit comments

Comments
 (0)