Moodle Code Checker update

[EJMFarrow]

Updating to the latest version of Code Checker leads to... 261229 errors! (Oh and 19 warnings which just feels like a joke at our expense to be honest.)

Fortunately 250,000 seem to be in the autogenerated files but still...

Most issues seem to be:

• Multi-line function calls need to be one argument per line and not on the same line as opening and closing brackets. And indented correctly.
• Lack of spaces around operators - mainly . for combining strings.

Hopefully we can use phpcbf to do most of the work as with #1168 - I will experiment. Will need to discuss when the best time to fix this is.

[sangwinc]

Thanks @EJMFarrow let's do that at the start of the next release cycle....

[EJMFarrow]

@sangwinc Yep, definitely. The question is probably whether it happens before or after Matti's changes being merged.

[aharjula]

Well, at least we can fix that bigger autogenerated file after the merge, as we now have full control over the parser generator and can get the layout "correct". The CASText parser will stay on PEG.js for a while, though. Rewriting that is on my to-do list, but it is a different type of parser, and I would rather focus on the /stack/maximasrc/ tooling now.

If most of the whines are about the names of the MP classes, those could naturally be renamed. I can now match their naming elsewhere by adding translation to the parser generator, if need be, so they have no need to stay the same.

Also, expect that the parser2 branch will start purging rather large bits of code, so maybe less to style. I threw away the static analysis mess already, more than 2kloc there...

[EJMFarrow]

Spot checks suggest a straight phpcbf . --standard=moodle --extensions=php seems to fix almost everything in a reasonable way. We're then just left with about 50 issues, mainly:

• Each class must be in a file by itself (I'd be tempted to override this error message rather than messing with anything)
• Property should not be prefixed with an underscore to indicate visibility (ditto)
• A few lines that are now too long

It would then be a case of fixing the autogeneration to produce similar output.
And then checking all the changes manually...