chore: _type as default anchor schema name config

Author: mattkhan

lib/anchor/concerns/type_inferable.rb

@@ -26,6 +26,10 @@ def method_added(method_name)
 
         # inspiration from https://github.com/rmosolgo/graphql-ruby/blob/eda9b3d62b9e507787e590f0f179ec9d6956255a/lib/graphql/schema/member/base_dsl_methods.rb?plain=1#L102
         def anchor_default_schema_name
+          # https://github.com/cerebris/jsonapi-resources/blob/d3c094b46a38650e583f40adc86474827b606fc7/lib/jsonapi/resource_common.rb?plain=1#L506
+          # https://github.com/cerebris/jsonapi-resources/blob/d3c094b46a38650e583f40adc86474827b606fc7/lib/jsonapi/resource_common.rb?plain=1#L564
+          return _type.to_s.classify if Anchor.config.use_type_as_schema_name
+
           s_name = name.split("::").last
           s_name.end_with?("Resource") ? s_name.sub(/Resource\Z/, "") : s_name
         end

lib/anchor/config.rb

@@ -5,7 +5,8 @@ class Config
       :use_active_record_presence,
       :use_active_record_comment,
       :infer_nullable_relationships_as_optional,
-      :empty_relationship_type
+      :empty_relationship_type,
+      :use_type_as_schema_name
 
     def initialize
       @ar_column_to_type = nil
@@ -14,6 +15,7 @@ def initialize
       @use_active_record_comment = nil
       @infer_nullable_relationships_as_optional = nil
       @empty_relationship_type = nil
+      @use_type_as_schema_name = nil
     end
   end
 end

spec/anchor/concerns/type_inferable_spec.rb

@@ -43,13 +43,43 @@ def one = 1
       end
 
       context "without schema name" do
+        around { |example| stub_jsonapi_resource_subclass("TestResources", &example) }
+
         it "uses the default schema name" do
           UserResource.class_eval do
             include Anchor::TypeInferable
           end
 
           expect(anchor_schema_name).to eql("User")
         end
+
+        context "without use_type_as_schema_name config enabled" do
+          before do
+            allow(Anchor.config).to receive(:use_type_as_schema_name).and_return(false)
+          end
+
+          it "uses the default schema name" do
+            TestResources.class_eval do
+              include Anchor::TypeInferable
+            end
+
+            expect(TestResources.anchor_schema_name).to eql("TestResources")
+          end
+        end
+
+        context "with use_type_as_schema_name config enabled" do
+          before do
+            allow(Anchor.config).to receive(:use_type_as_schema_name).and_return(true)
+          end
+
+          it "uses classified _type" do
+            TestResources.class_eval do
+              include Anchor::TypeInferable
+            end
+
+            expect(TestResources.anchor_schema_name).to eql("TestResource")
+          end
+        end
       end
     end
 

spec/support/stub.rb

@@ -1,9 +1,11 @@
 # rubocop:disable RSpec/RemoveConst, Security/Eval
 def stub_jsonapi_resource_subclass(name, &example)
   previously_defined = Object.const_defined?(name)
-  previous_klass = name.constantize
 
-  Object.send(:remove_const, name) if previously_defined
+  if previously_defined
+    previous_klass = name.constantize
+    Object.send(:remove_const, name)
+  end
 
   klass_string = <<~EVAL
     class #{name} < JSONAPI::Resource