Skip to content

Commit 0f5dcb4

Browse files
authored
Merge pull request #192 from mcci-catena/issue191
Fix #191: missing return value, thx @surfermarty
2 parents caceeb4 + acb1dd9 commit 0f5dcb4

File tree

3 files changed

+28
-22
lines changed

3 files changed

+28
-22
lines changed

README.md

Lines changed: 25 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -21,28 +21,28 @@
2121
- [Overview](#overview)
2222
- [Required libraries](#required-libraries)
2323
- [Compile-time Configuration](#compile-time-configuration)
24-
- [Region Selection](#region-selection)
25-
- [Network selection](#network-selection)
26-
- [Join Subband Selection](#join-subband-selection)
24+
- [Region Selection](#region-selection)
25+
- [Network selection](#network-selection)
26+
- [Join Subband Selection](#join-subband-selection)
2727
- [Writing Code With This Library](#writing-code-with-this-library)
28-
- [Using the LMIC's pre-configured pin-maps](#using-the-lmics-pre-configured-pin-maps)
29-
- [Supplying a pin-map](#supplying-a-pin-map)
30-
- [Details on use](#details-on-use)
28+
- [Using the LMIC's pre-configured pin-maps](#using-the-lmics-pre-configured-pin-maps)
29+
- [Supplying a pin-map](#supplying-a-pin-map)
30+
- [Details on use](#details-on-use)
3131
- [APIs](#apis)
32-
- [Starting operation](#starting-operation)
33-
- [Poll and update the LMIC](#poll-and-update-the-lmic)
34-
- [Reset the LMIC](#reset-the-lmic)
35-
- [Shut down the LMIC](#shut-down-the-lmic)
36-
- [Register an event listener](#register-an-event-listener)
37-
- [Send an event to all listeners](#send-an-event-to-all-listeners)
38-
- [Manipulate the Debug Mask](#manipulate-the-debug-mask)
39-
- [Output a formatted log message](#output-a-formatted-log-message)
40-
- [Get the configured LoRaWAN region, country code, and network name](#get-the-configured-lorawan-region-country-code-and-network-name)
41-
- [Set link-check mode](#set-link-check-mode)
42-
- [Send a buffer](#send-a-buffer)
43-
- [Register a Receive-Buffer Callback](#register-a-receive-buffer-callback)
44-
- [Get DevEUI, AppEUI, AppKey](#get-deveui-appeui-appkey)
45-
- [Test provisioning state](#test-provisioning-state)
32+
- [Starting operation](#starting-operation)
33+
- [Poll and update the LMIC](#poll-and-update-the-lmic)
34+
- [Reset the LMIC](#reset-the-lmic)
35+
- [Shut down the LMIC](#shut-down-the-lmic)
36+
- [Register an event listener](#register-an-event-listener)
37+
- [Send an event to all listeners](#send-an-event-to-all-listeners)
38+
- [Manipulate the Debug Mask](#manipulate-the-debug-mask)
39+
- [Output a formatted log message](#output-a-formatted-log-message)
40+
- [Get the configured LoRaWAN region, country code, and network name](#get-the-configured-lorawan-region-country-code-and-network-name)
41+
- [Set link-check mode](#set-link-check-mode)
42+
- [Send a buffer](#send-a-buffer)
43+
- [Register a Receive-Buffer Callback](#register-a-receive-buffer-callback)
44+
- [Get DevEUI, AppEUI, AppKey](#get-deveui-appeui-appkey)
45+
- [Test provisioning state](#test-provisioning-state)
4646
- [Examples](#examples)
4747
- [Release History](#release-history)
4848
- [Notes](#notes)
@@ -424,10 +424,14 @@ However, [examples/simple_sensor_bme280](examples/simple_sensor_bme280/simple_se
424424
425425
**Note**: the example uses the MCCI fork of the Adafruit BME280 library, found [here](https://github.com/mcci-catena/Adafruit_BME280_Library). This won't trouble you unless you actually try to use the code, rather than replacing the sensor logic with your own logic.
426426
427-
Much more elaborate uses can be found in the MCCI [Catena-Arduino-Platform](https://github.com/mcci-catena/Catena-Arduino-Platform) library; but that library is so large that it's tough to figure out what's required for LoRaWAN, and what's used for supporting our boards.
427+
Much more elaborate uses can be found in the MCCI [Catena-Arduino-Platform](https://github.com/mcci-catena/Catena-Arduino-Platform) library; but that library is so large that it's tough to figure out what's required for LoRaWAN, and what's used for supporting MCCI boards.
428428
429429
## Release History
430430
431+
- Head includes the following changes.
432+
433+
- Correct error in logging, missing `return true` in `Arduino_LoRaWAN::cEventLog::processSingleEvent()` ([#191](https://github.com/mcci-catena/arduino-lorawan/issues/169)). This is v0.9.2-pre1.
434+
431435
- v0.9.1 includes the following changes.
432436
433437
- Check size and tag of SessionChannelMask when restoring a session ([#169](https://github.com/mcci-catena/arduino-lorawan/issues/169)).

src/Arduino_LoRaWAN.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ Copyright notice:
3434
/// \ref ARDUINO_LORAWAN_VERSION_COMPARE_LT() to compare relative versions.
3535
///
3636
#define ARDUINO_LORAWAN_VERSION \
37-
ARDUINO_LORAWAN_VERSION_CALC(0, 9, 1, 0) /* v0.9.1 */
37+
ARDUINO_LORAWAN_VERSION_CALC(0, 9, 2, 1) /* v0.9.2-pre1 */
3838

3939
#define ARDUINO_LORAWAN_VERSION_GET_MAJOR(v) \
4040
(((v) >> 24u) & 0xFFu)

src/lib/arduino_lorawan_cEventLog.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,8 @@ Arduino_LoRaWAN::cEventLog::processSingleEvent()
103103
{
104104
m_head = 0;
105105
}
106+
107+
return true;
106108
}
107109

108110
void

0 commit comments

Comments
 (0)