Skip to content

Commit 15eca81

Browse files
committed
ci(release): revert explicit --release (fragile); rely on mcpp.toml default-profile
The 0.0.77 release failed at the musl build step with 'unknown option: --release': release.yml's bootstrap (`xlings install mcpp`) can resolve an OLDER mcpp (stale CI index → old 'latest') that predates the --release flag, even though the pin is 0.0.76. So explicit --release in the release pipeline is fragile. The robust mechanism is mcpp.toml's default-profile="release", which keeps the shipped artifact -O2 with no flag (old bootstraps default to release anyway, 0.0.76+ read the manifest knob). Reverts #16's change.
1 parent af786d0 commit 15eca81

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

.github/workflows/release.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ jobs:
128128
129129
# Build first so we can strip the ELF before pack copies it.
130130
export MCPP_VENDORED_XLINGS="$XLINGS_BIN"
131-
"$MCPP" build --release --target x86_64-linux-musl
131+
"$MCPP" build --target x86_64-linux-musl
132132
ARTIFACT=$(find target/x86_64-linux-musl -type f -name mcpp | head -1)
133133
test -n "$ARTIFACT"
134134
file "$ARTIFACT" | grep -q 'statically linked'
@@ -307,10 +307,10 @@ jobs:
307307
# (the feature landed after the last release), so it resolves the
308308
# x86_64 host musl-gcc for an aarch64 target. Two-stage instead: build
309309
# THIS release's x86_64 mcpp first, then cross-build aarch64 with it.
310-
mcpp build --release --target x86_64-linux-musl
310+
mcpp build --target x86_64-linux-musl
311311
FRESH=$(find target/x86_64-linux-musl -type f -name mcpp | head -1)
312312
test -n "$FRESH"
313-
"$FRESH" build --release --target aarch64-linux-musl
313+
"$FRESH" build --target aarch64-linux-musl
314314
BIN=$(find target/aarch64-linux-musl -type f -name mcpp | head -1)
315315
test -n "$BIN"
316316
file "$BIN" | grep -q 'ARM aarch64'
@@ -455,7 +455,7 @@ jobs:
455455
# bootstrap's macOS link path predates the staticStdlib
456456
# implementation (hardcoded -lc++), so stage 1 links the system
457457
# libc++ — fine, it only needs to RUN on this runner.
458-
"$MCPP" build --release
458+
"$MCPP" build
459459
STAGE1=$(find target -path "*/bin/mcpp" | head -1)
460460
STAGE1=$(cd "$(dirname "$STAGE1")" && pwd)/$(basename "$STAGE1")
461461
"$STAGE1" --version
@@ -466,7 +466,7 @@ jobs:
466466
# fingerprint includes the deployment target; the bootstrap's
467467
# did not) — pick the most recently modified binary, not the
468468
# first find hit.
469-
"$STAGE1" build --release --no-cache
469+
"$STAGE1" build --no-cache
470470
MCPP_BIN=$(ls -t $(find target -path "*/bin/mcpp" -type f) | head -1)
471471
MCPP_BIN=$(cd "$(dirname "$MCPP_BIN")" && pwd)/$(basename "$MCPP_BIN")
472472
test -x "$MCPP_BIN"
@@ -629,7 +629,7 @@ jobs:
629629
run: |
630630
export MCPP_VENDORED_XLINGS="$XLINGS_BIN"
631631
632-
"$MCPP" build --release
632+
"$MCPP" build
633633
634634
MCPP_BIN=$(find target -name "mcpp.exe" -path "*/bin/*" | head -1)
635635
test -n "$MCPP_BIN" || { echo "FAIL: no mcpp.exe in target/"; exit 1; }

0 commit comments

Comments
 (0)