Skip to content

Commit 3effb94

Browse files
committed
ci: pin legacy smoke to 0.0.46, examples to 0.0.67 (isolate version bump)
The whole-suite portable/full smoke fails on 0.0.67 because that mcpp honors the gtest `main` feature gating (gtest_main.cc excluded by default → the legacy gtest smoke link-errors on undefined main). That is pre-existing drift unrelated to cJSON/nlohmann; updating those smoke scripts belongs in its own PR. Scope the version: new example jobs run on current 0.0.67 (what users have, already green), legacy regression stays on its authored 0.0.46.
1 parent 77fd785 commit 3effb94

1 file changed

Lines changed: 16 additions & 6 deletions

File tree

.github/workflows/validate.yml

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,9 @@ on:
1010
- cron: "0 6 * * *"
1111
workflow_dispatch:
1212

13-
env:
14-
MCPP_VERSION: "0.0.67"
13+
# Note: mcpp version is pinned per-job, not globally. The new per-package
14+
# example jobs run on the current release (what real users have); the legacy
15+
# whole-suite regression stays on the version it was authored against.
1516

1617
jobs:
1718
lint:
@@ -150,6 +151,8 @@ jobs:
150151
needs: detect
151152
if: needs.detect.outputs.examples != '[]'
152153
runs-on: ubuntu-latest
154+
env:
155+
MCPP_VERSION: "0.0.67"
153156
strategy:
154157
fail-fast: false
155158
matrix:
@@ -186,6 +189,11 @@ jobs:
186189
needs: detect
187190
if: needs.detect.outputs.full == 'true'
188191
runs-on: ubuntu-latest
192+
env:
193+
# legacy whole-suite smoke is pinned to the version it was authored
194+
# against; bumping it surfaces unrelated package/version drift (e.g. the
195+
# gtest `main` feature gating) that belongs in a separate maintenance PR.
196+
MCPP_VERSION: "0.0.46"
189197
steps:
190198
- uses: actions/checkout@v4
191199
- name: Restore mcpp registry cache
@@ -225,20 +233,22 @@ jobs:
225233
name: smoke-${{ matrix.platform }}
226234
runs-on: ${{ matrix.os }}
227235
timeout-minutes: 60
236+
env:
237+
MCPP_VERSION: "0.0.46"
228238
strategy:
229239
fail-fast: false
230240
matrix:
231241
include:
232242
- platform: macos
233243
os: macos-15
234-
archive: mcpp-0.0.67-macosx-arm64.tar.gz
235-
root: mcpp-0.0.67-macosx-arm64
244+
archive: mcpp-0.0.46-macosx-arm64.tar.gz
245+
root: mcpp-0.0.46-macosx-arm64
236246
mcpp: bin/mcpp
237247
xlings: registry/bin/xlings
238248
- platform: windows
239249
os: windows-latest
240-
archive: mcpp-0.0.67-windows-x86_64.zip
241-
root: mcpp-0.0.67-windows-x86_64
250+
archive: mcpp-0.0.46-windows-x86_64.zip
251+
root: mcpp-0.0.46-windows-x86_64
242252
mcpp: bin/mcpp.exe
243253
xlings: registry/bin/xlings.exe
244254
steps:

0 commit comments

Comments
 (0)