fix: allow embeds to be removed if all fields are undefined

Author: quirky-bluejay

src/interactions/buttons/message-generation.ts

@@ -346,6 +346,22 @@ const handleSend = async ({
     url: messageLink,
     timestamp: new Date().toISOString(),
   };
+  // Check embed for any set values. If none set embed to undefined
+  if (currentStatus.embed !== undefined) {
+    const hasAnySet =
+      (currentStatus.embed?.fields?.length ?? 0) > 0 ||
+      currentStatus.embed?.author?.name !== undefined ||
+      currentStatus.embed?.footer?.text !== undefined ||
+      currentStatus.embed?.description !== undefined ||
+      currentStatus.embed?.title !== undefined ||
+      currentStatus.embed?.url !== undefined ||
+      currentStatus.embed?.thumbnail?.url !== undefined ||
+      currentStatus.embed?.timestamp !== undefined ||
+      currentStatus.embed?.color !== undefined;
+    if (!hasAnySet) {
+      currentStatus.embed = undefined;
+    }
+  }
 
   return {
     type: InteractionResponseType.UpdateMessage,
@@ -382,6 +398,23 @@ const handleEdit = async ({
     );
   }
 
+  // Check embed for any set values. If none set embed to undefined
+  if (currentStatus.embed !== undefined) {
+    const hasAnySet =
+      (currentStatus.embed?.fields?.length ?? 0) > 0 ||
+      currentStatus.embed?.author?.name !== undefined ||
+      currentStatus.embed?.footer?.text !== undefined ||
+      currentStatus.embed?.description !== undefined ||
+      currentStatus.embed?.title !== undefined ||
+      currentStatus.embed?.url !== undefined ||
+      currentStatus.embed?.thumbnail?.url !== undefined ||
+      currentStatus.embed?.timestamp !== undefined ||
+      currentStatus.embed?.color !== undefined;
+    if (!hasAnySet) {
+      currentStatus.embed = undefined;
+    }
+  }
+
   await editMessage({
     channelId,
     messageId: currentStatus.messageId,

src/interactions/shared/message-generation.ts

@@ -59,6 +59,7 @@ const createInitialMessageGenerationEmbed = (
       }`,
       description:
         `Use the buttons below to update the state of the message and embed. When you are done, click the ${type} button.` +
+        `\nTo remove the embed, if you have not already done so, make sure all fields and other properties are removed (empty)` +
         "\n\n" +
         `${
           currentStatus.content !== undefined
@@ -175,7 +176,8 @@ const createEmbedMessageGenerationEmbed = (
     embed: addTipToEmbed({
       title: "Message Generation Flow - Embed",
       description:
-        "Use the buttons below to update the state of the embed. When you are done, click the back button.",
+        "Use the buttons below to update the state of the embed. When you are done, click the back button." +
+        "\nTo remove the embed, if you have not already done so, make sure all fields and other properties are removed (empty)",
       color: embedPink,
     }),
     components: [