fix: errors when webhook status changes

Remove logging channel if channel has been deleted
Remove webhook if webhook has been deleted and attempt to create another
Await promise in try catch block

Author: quirky-bluejay

src/interactions/commands/chatInput/config.ts

@@ -598,6 +598,7 @@ async function handleLoggingChannelSetSubcommand({
       guildId: interaction.guild_id,
       embeds: [logEmbed],
       ignoreErrors: false,
+      session,
     });
   }
   // If this fails it will be returned to the user

src/lib/logging/manager.ts

@@ -1,6 +1,6 @@
-import { RawFile } from "@discordjs/rest";
+import { RawFile, DiscordAPIError } from "@discordjs/rest";
 import { Snowflake } from "discord-api-types/globals";
-import { APIEmbed, APIMessage } from "discord-api-types/v9";
+import { APIEmbed, APIMessage, RESTJSONErrorCodes } from "discord-api-types/v9";
 import { FastifyInstance } from "fastify";
 
 import { DiscordPermissions } from "../../consts";
@@ -84,13 +84,15 @@ export default class LoggingManager {
     message,
     embeds,
     files,
+    session,
   }: {
     guildId: Snowflake;
 
     ignoreErrors?: boolean;
     message?: string;
     embeds: APIEmbed[] | undefined;
     files?: RawFile[];
+    session: GuildSession;
   }): Promise<APIMessage | void> {
     // Logs can be "passed" if the channel isn't set, or if the webhook doesn't exist and the bot cannot create a new webhook
     // This means that this function can be called without checking if the log channel is set
@@ -107,14 +109,26 @@ export default class LoggingManager {
     };
 
     try {
-      return this._webhookManager.sendWebhookMessage(
+      return await this._webhookManager.sendWebhookMessage(
+        // TODO: ADD AWAIT
         channelId,
         guildId,
         data,
         files
       );
       // eslint-disable-next-line no-empty
     } catch (error) {
+      if (
+        error instanceof DiscordAPIError &&
+        error.code === RESTJSONErrorCodes.UnknownChannel
+      ) {
+        // remove channel
+        // This threw on the attempt to add / create a webhook on the channel
+        // This is because the channel doesn't exist anymore
+        await this.removeGuildLoggingChannel(session);
+        return;
+      }
+
       if (!(ignoreErrors ?? false)) {
         throw error;
       }

src/lib/messages/delete.ts

@@ -239,10 +239,9 @@ async function deleteMessage({
         "\n\nEmbed representation can be found in the attachment.";
     }
     // Send log message
-    await instance.loggingManager.sendLogMessage({
-      guildId: session.guildId,
-      embeds: [logEmbed],
-      files,
+    await session.sendLoggingMessage({
+      logEmbeds: [logEmbed],
+      files: files,
     });
   } catch (error) {
     if (error instanceof DiscordAPIError) {

src/lib/messages/edit.ts

@@ -381,10 +381,10 @@ async function editMessage({
     }
 
     // Send log message
-    await instance.loggingManager.sendLogMessage({
-      guildId: session.guildId,
-      embeds: [logEmbed],
-      files,
+
+    await session.sendLoggingMessage({
+      logEmbeds: [logEmbed],
+      files: files,
     });
   } catch (error) {
     if (error instanceof DiscordAPIError) {

src/lib/messages/send.ts

@@ -274,10 +274,9 @@ async function sendMessage({
         "\n\nEmbed representation can be found in the attachment.";
     }
     // Send log message
-    await instance.loggingManager.sendLogMessage({
-      guildId: session.guildId,
-      embeds: [logEmbed],
-      files,
+    await session.sendLoggingMessage({
+      logEmbeds: [logEmbed],
+      files: files,
     });
     return messageResult;
   } catch (error) {

src/lib/permissions/manager.ts

@@ -95,7 +95,7 @@ class PermissionManager {
       actionBy: session.userId,
       actionType: ActionType.GENERAL,
     });
-    await session.sendLoggingMessage(embed);
+    await session.sendLoggingMessage({ logEmbeds: [embed] });
   }
 
   private async _sendAllowDenyLogMessage({
@@ -179,7 +179,7 @@ class PermissionManager {
       actionBy: session.userId,
       actionType: ActionType.GENERAL,
     });
-    await session.sendLoggingMessage(embed);
+    await session.sendLoggingMessage({ logEmbeds: [embed] });
   }
 
   async getAllGuildPermissions(

src/lib/session/index.ts

@@ -1,3 +1,4 @@
+import { RawFile } from "@discordjs/rest";
 import { Snowflake } from "discord-api-types/globals";
 import {
   APIDMInteraction,
@@ -126,11 +127,22 @@ class GuildSession {
     });
   }
 
-  async sendLoggingMessage(logEmbed: APIEmbed): Promise<void> {
+  async sendLoggingMessage({
+    logEmbeds,
+    message,
+    files,
+  }: {
+    logEmbeds?: APIEmbed[];
+    message?: string;
+    files?: RawFile[];
+  }): Promise<void> {
     await this._instance.loggingManager.sendLogMessage({
-      embeds: [logEmbed],
+      embeds: logEmbeds,
+      message,
+      files,
       guildId: this.guildId,
       ignoreErrors: true,
+      session: this,
     });
   }
 }

src/lib/webhook/manager.ts

@@ -3,6 +3,7 @@ import { Snowflake } from "discord-api-types/globals";
 import {
   APIMessage,
   RESTGetAPIChannelWebhooksResult,
+  RESTJSONErrorCodes,
   RESTPostAPIChannelWebhookResult,
   RESTPostAPIWebhookWithTokenJSONBody,
   RESTPostAPIWebhookWithTokenWaitResult,
@@ -54,6 +55,29 @@ export default class WebhookManager {
       },
     });
   }
+  private _removeStoredWebhook(
+    channelId: Snowflake,
+    guildId: Snowflake
+  ): Promise<unknown> {
+    return this._instance.prisma.channel.upsert({
+      where: { id: BigInt(channelId) },
+      update: { webhookId: null, webhookToken: null },
+      create: {
+        id: BigInt(channelId),
+        webhookId: null,
+        webhookToken: null,
+        guild: {
+          connectOrCreate: {
+            where: { id: BigInt(guildId) },
+
+            create: {
+              id: BigInt(guildId),
+            },
+          },
+        },
+      },
+    });
+  }
 
   private async _getWebhookFromDiscord(
     channelId: Snowflake,
@@ -120,6 +144,7 @@ export default class WebhookManager {
     }
     // If here this means that there are no webhooks that match the application id, and the token is null
     // Therefore we need to create a new webhook
+
     return await this._createWebhook(channelId, guildId);
   }
   private async _createWebhook(
@@ -138,7 +163,10 @@ export default class WebhookManager {
       )) as RESTPostAPIChannelWebhookResult;
     } catch (error) {
       if (error instanceof DiscordAPIError) {
-        if (error.code === 403 || error.code === 50013) {
+        if (
+          error.status === 403 ||
+          error.code === RESTJSONErrorCodes.MissingPermissions
+        ) {
           throw new UnexpectedFailure(
             InteractionOrRequestFinalStatus.BOT_MISSING_DISCORD_PERMISSION,
             "Missing the permission `MANAGE_WEBHOOKS` on that channel"
@@ -193,15 +221,28 @@ export default class WebhookManager {
     files?: RawFile[]
   ): Promise<APIMessage> {
     const webhook = await this.getWebhook(channelId, guildId);
-
-    const message = (await this._instance.restClient.post(
-      Routes.webhook(webhook.id, webhook.token),
-      {
-        body: data,
-        files,
-        query: new URLSearchParams({ wait: "true" }),
+    try {
+      const message = (await this._instance.restClient.post(
+        Routes.webhook(webhook.id, webhook.token),
+        {
+          body: data,
+          files,
+          query: new URLSearchParams({ wait: "true" }),
+        }
+      )) as RESTPostAPIWebhookWithTokenWaitResult;
+      return message;
+    } catch (error) {
+      if (
+        error instanceof DiscordAPIError &&
+        error.code === RESTJSONErrorCodes.UnknownWebhook
+      ) {
+        // If the webhook is not found, it means that it has been deleted, so we need to recreate it
+        // First delete the webhook so it is not attempted to be used again, incase creating the webhook fails
+        await this._removeStoredWebhook(channelId, guildId);
+        await this._createWebhook(channelId, guildId);
+        return await this.sendWebhookMessage(channelId, guildId, data, files);
       }
-    )) as RESTPostAPIWebhookWithTokenWaitResult;
-    return message;
+      throw error;
+    }
   }
 }