feat: move management roles to seperate permissions

Author: quirky-bluejay

package-lock.json

@@ -0,0 +1,12 @@
+/*
+  Warnings:
+
+  - You are about to drop the column `managementRoleIds` on the `Guild` table. All the data in the column will be lost.
+  - You are about to drop the column `tags` on the `Message` table. All the data in the column will be lost.
+
+*/
+-- AlterTable
+ALTER TABLE "Guild" DROP COLUMN "managementRoleIds";
+
+-- AlterTable
+ALTER TABLE "Message" DROP COLUMN "tags";

prisma/migrations/20220425103732_remove_management_roles/migration.sql

@@ -26,7 +26,6 @@ model Guild {
   permissions Json? 
   beforeMigration Boolean @default(false) // This indicates if the guild existed before the migration to storing message content. 
   // If it was it gains access to adding any previous bot sent message to the database.
-  managementRoleIds BigInt[]
   messages Message[]
   channels Channel[]
 }

prisma/schema.prisma

@@ -35,44 +35,7 @@
           }
         ]
       },
-      {
-        "name": "management-roles",
-        "type": 2,
-        "description": "Manage who can manage permissions, and other configuration. Require administrator permissions.",
-        "options": [
-          {
-            "name": "add",
-            "type": 1,
-            "description": "Make a role a bot management role.",
-            "options": [
-              {
-                "type": 8,
-                "name": "role",
-                "required": true,
-                "description": "The role to make a bot management role."
-              }
-            ]
-          },
-          {
-            "name": "remove",
-            "type": 1,
-            "description": "Remove a role from being a bot management role",
-            "options": [
-              {
-                "type": 8,
-                "name": "role",
-                "required": true,
-                "description": "The role to set the permission for"
-              }
-            ]
-          },
-          {
-            "name": "list",
-            "type": 1,
-            "description": "List all bot management roles"
-          }
-        ]
-      },
+
       {
         "name": "permissions",
         "type": 2,
@@ -110,6 +73,14 @@
                   {
                     "name": "Delete Messages",
                     "value": 4
+                  },
+                  {
+                    "name": "Manage Permissions",
+                    "value": 5
+                  },
+                  {
+                    "name": "Manage Config",
+                    "value": 6
                   }
                 ]
               },

src/discord_commands/global.json

@@ -25,18 +25,18 @@ enum InteractionOrRequestFinalStatus {
   REPORT_ALREADY_SUBMITTED,
   BOT_FOUND_WHEN_USER_EXPECTED,
   NO_PERMISSION_TO_REMOVE,
-  NO_MANAGEMENT_ROLE_TO_REMOVE,
   TAG_NOT_FOUND,
+  MANAGE_CONFIG_PERMISSION_CANNOT_BE_SET_ON_CHANNEL_LEVEL,
   GENERIC_EXPECTED_PERMISSIONS_FAILURE = 3000,
   USER_MISSING_DISCORD_PERMISSION,
   BOT_MISSING_DISCORD_PERMISSION,
   USER_MISSING_INTERNAL_BOT_PERMISSION,
   BOT_MISSING_DISCORD_SCOPE,
-  USER_MISSING_INTERNAL_BOT_MANAGEMENT_PERMISSION,
+  USER_ROLES_NOT_HIGH_ENOUGH,
+  USER_ATTEMPTED_TO_EDIT_PERMISSION_ABOVE_THEIR_PERMISSION,
   GENERIC_EXPECTED_OAUTH_FAILURE = 4000,
   OATUH_TOKEN_EXPIRED,
   GENERIC_EXPECTED_LIMIT_FAILURE = 5000,
-  MAX_MANAGEMENT_ROLES,
   MAX_ROLE_PERMISSIONS,
   MAX_USER_PERMISSIONS,
   MAX_ROLE_CHANNEL_PERMISSIONS,
@@ -59,6 +59,7 @@ enum InteractionOrRequestFinalStatus {
   GUILD_COMPONENT_IN_DM_INTERACTION,
   OAUTH_REQUEST_FAILED,
   CREATE_WEBHOOK_RESULT_MISSING_TOKEN,
+  ROLE_NOT_IN_CACHE,
 }
 
 class CustomError extends Error {