Skip to content

Commit 9db16fd

Browse files
dmealingclaude
dmealing
and
claude
committed
feat(metadata): FR-015 @parameterRef on source.rdb for typed callable inputs
Adds the metamodel + loader layer for FR-015 — the @parameterRef attribute that lets a callable source (storedProc / tableFunction) reference an object.value describing its input parameter shape. The pattern mirrors template.@payloadRef from FR-004, reusing the existing object.value mechanism rather than introducing a new parameter.* node type. Implementation (server/typescript/packages/metadata): - SOURCE_ATTR_PARAMETER_REF = "parameterRef" constant in source-constants.ts. - AttrSchema entry on sourceRdbAttrs (string, optional). - New validation pass validate-source-parameter-ref.ts emits: * ERR_PARAMETER_REF_UNRESOLVED — @parameterRef names a non-existent object. * ERR_PARAMETER_REF_NOT_VALUE_OBJECT — references object.entity not object.value. * ERR_PARAMETER_REF_ON_NON_CALLABLE_KIND — set on table/view/materializedView. * ERR_PARAMETER_REF_PASSTHROUGH_TYPE_MISMATCH — parameter field uses origin.passthrough whose @from references a field of a different subtype. - 4 new codes registered in errors.ts + the shared ERROR-CODES.json registry. Conformance fixtures (10 under fixtures/conformance/): - 6 positive: parameter-ref-on-stored-proc, parameter-ref-on-table-function, parameter-ref-with-origin-passthrough, parameter-ref-shared-across-procs, parameter-ref-optional-parameter, parameter-ref-no-args. - 4 error: error-parameter-ref-unresolved, error-parameter-ref-not-value-object, error-parameter-ref-on-table-kind, error-parameter-ref-passthrough-type-mismatch. Cross-port enum parity (so other ports' enum-vs-corpus checks stay green): - Java ErrorCode enum: added all 4 FR-015 codes (+ FR-013 codes that the earlier FR-016 ledger update had deferred). - C# ErrorCode enum: added all 4 FR-015 codes + FR-013 codes. - Python ErrorCode enum: added all 4 FR-015 codes. Conformance ledgers updated (Java / C# / Python) to defer the 4 FR-015 error fixtures and the FR-013 error fixtures until each port ships those FRs. Note: ERR_PARAMETER_REF_REQUIRED_FOR_CALLABLE from the FR-015 design was dropped from load-time validation — the "does the proc take args" decision needs DB introspection, so it belongs in migrate-ts verify, not the loader. Tests: 12 dedicated unit tests in fr015-source-parameter-ref.test.ts plus the 10 conformance fixtures. Full TS metadata suite: 1448 pass / 0 fail. Out of scope for this commit (still on the plan): - codegen-ts repo-method emission for storedProc / tableFunction sources. - The @exposeAsRoute decision (per FR-015 §"REST exposure" follow-on). - migrate-ts pg_proc introspection + signature drift detection (sister plan). - Per-port FR-015 fan-out (Java / Kotlin / C# / Python). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 parent 9a170c6 commit 9db16fd

33 files changed

Lines changed: 1280 additions & 6 deletions

File tree

‎fixtures/conformance/ERROR-CODES.json‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,10 @@
3636
"ERR_PHYSICAL_NAME_MULTIPLE": "FR-016 / ADR-0018: a source.rdb declares two or more kind-aware physical-name aliases at once (e.g. both @table and @view). Exactly one is permitted.",
3737
"ERR_READONLY_ASSIGNED_PRIMARY": "FR-013: a field with @readOnly: true is the target of an identity.primary with @generation: \"assigned\". The application has no path to populate the identity value (no setter; not generated; not defaulted).",
3838
"ERR_READONLY_DOWNGRADE": "FR-013: a concrete entity declares @readOnly: false on a field whose extends-chain parent declares @readOnly: true. Read-only-ness can only be upgraded, never downgraded.",
39+
"ERR_PARAMETER_REF_UNRESOLVED": "FR-015: source.rdb @parameterRef names an object that does not exist in the loaded model.",
40+
"ERR_PARAMETER_REF_NOT_VALUE_OBJECT": "FR-015: source.rdb @parameterRef references an object.entity instead of object.value. Input shapes are value-objects by definition (no identity).",
41+
"ERR_PARAMETER_REF_ON_NON_CALLABLE_KIND": "FR-015: source.rdb @parameterRef is set with @kind: \"table\" / \"view\" / \"materializedView\". These kinds do not accept parameters; only \"storedProc\" / \"tableFunction\" do.",
42+
"ERR_PARAMETER_REF_PASSTHROUGH_TYPE_MISMATCH": "FR-015: a parameter field uses origin.passthrough @from: \"Entity.field\" but the parameter's subtype does not match the referenced field's subtype (drift gate).",
3943
"ERR_YAML_COERCION": "A YAML 1.2 silent type coercion produced a value whose runtime type differs from the attribute's declared valueType (e.g. an unquoted `column: TRUE` parsed as boolean for a string-typed attr). Emitted by every port's YAML loader; canonical JSON is unaffected.",
4044
"ERR_MERGE_CONFLICT": "FR5c: multi-file overlay merge produced an attribute conflict — two contributing files declared the same @attr with different non-empty values on the same logical node. Envelope is `format: \"merged\"` with `contributors[]` naming both files.",
4145
"ERR_UNKNOWN": "An internal loader error with no stable error code."

‎fixtures/conformance/error-parameter-ref-not-value-object/expected-errors.json‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
{
2+
"errors": [
3+
{
4+
"code": "ERR_PARAMETER_REF_NOT_VALUE_OBJECT",
5+
"source": {
6+
"format": "json",
7+
"files": [
8+
"meta.demo.json"
9+
],
10+
"jsonPath": "$['metadata.root'].children[1]['object.entity'].children[0]['source.rdb']"
11+
}
12+
}
13+
],
14+
"warnings": []
15+
}

‎fixtures/conformance/error-parameter-ref-not-value-object/input/meta.demo.json‎

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
{
2+
"metadata.root": {
3+
"package": "demo",
4+
"children": [
5+
{
6+
"object.entity": {
7+
"name": "Customer",
8+
"children": [
9+
{ "source.rdb": { "@table": "customers" } },
10+
{ "field.long": { "name": "id" } },
11+
{ "identity.primary": { "@fields": "id" } }
12+
]
13+
}
14+
},
15+
{
16+
"object.entity": {
17+
"name": "BadProc",
18+
"children": [
19+
{
20+
"source.rdb": {
21+
"@kind": "storedProc",
22+
"@proc": "fn_x",
23+
"@parameterRef": "Customer"
24+
}
25+
},
26+
{ "field.long": { "name": "id" } },
27+
{ "identity.primary": { "@fields": "id" } }
28+
]
29+
}
30+
}
31+
]
32+
}
33+
}

‎fixtures/conformance/error-parameter-ref-on-table-kind/expected-errors.json‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
{
2+
"errors": [
3+
{
4+
"code": "ERR_PARAMETER_REF_ON_NON_CALLABLE_KIND",
5+
"source": {
6+
"format": "json",
7+
"files": [
8+
"meta.demo.json"
9+
],
10+
"jsonPath": "$['metadata.root'].children[1]['object.entity'].children[0]['source.rdb']"
11+
}
12+
}
13+
],
14+
"warnings": []
15+
}

‎fixtures/conformance/error-parameter-ref-on-table-kind/input/meta.demo.json‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
{
2+
"metadata.root": {
3+
"package": "demo",
4+
"children": [
5+
{
6+
"object.value": {
7+
"name": "Args",
8+
"children": [
9+
{ "field.int": { "name": "x" } }
10+
]
11+
}
12+
},
13+
{
14+
"object.entity": {
15+
"name": "RegularTable",
16+
"children": [
17+
{
18+
"source.rdb": {
19+
"@table": "regular_table",
20+
"@parameterRef": "Args"
21+
}
22+
},
23+
{ "field.long": { "name": "id" } },
24+
{ "identity.primary": { "@fields": "id" } }
25+
]
26+
}
27+
}
28+
]
29+
}
30+
}

‎fixtures/conformance/error-parameter-ref-passthrough-type-mismatch/expected-errors.json‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
{
2+
"errors": [
3+
{
4+
"code": "ERR_PARAMETER_REF_PASSTHROUGH_TYPE_MISMATCH",
5+
"source": {
6+
"format": "json",
7+
"files": [
8+
"meta.demo.json"
9+
],
10+
"jsonPath": "$['metadata.root'].children[1]['object.value'].children[0]['field.int']"
11+
}
12+
}
13+
],
14+
"warnings": []
15+
}

‎fixtures/conformance/error-parameter-ref-passthrough-type-mismatch/input/meta.demo.json‎

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
{
2+
"metadata.root": {
3+
"package": "demo",
4+
"children": [
5+
{
6+
"object.entity": {
7+
"name": "Case",
8+
"children": [
9+
{ "source.rdb": { "@table": "cases" } },
10+
{ "field.string": { "name": "label" } },
11+
{ "field.long": { "name": "id" } },
12+
{ "identity.primary": { "@fields": "id" } }
13+
]
14+
}
15+
},
16+
{
17+
"object.value": {
18+
"name": "Args",
19+
"children": [
20+
{
21+
"field.int": {
22+
"name": "label",
23+
"children": [
24+
{ "origin.passthrough": { "@from": "Case.label" } }
25+
]
26+
}
27+
}
28+
]
29+
}
30+
},
31+
{
32+
"object.entity": {
33+
"name": "Proc",
34+
"children": [
35+
{
36+
"source.rdb": {
37+
"@kind": "storedProc",
38+
"@proc": "fn_x",
39+
"@parameterRef": "Args"
40+
}
41+
},
42+
{ "field.long": { "name": "id" } },
43+
{ "identity.primary": { "@fields": "id" } }
44+
]
45+
}
46+
}
47+
]
48+
}
49+
}

‎fixtures/conformance/error-parameter-ref-unresolved/expected-errors.json‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
{
2+
"errors": [
3+
{
4+
"code": "ERR_PARAMETER_REF_UNRESOLVED",
5+
"source": {
6+
"format": "json",
7+
"files": [
8+
"meta.demo.json"
9+
],
10+
"jsonPath": "$['metadata.root'].children[0]['object.entity'].children[0]['source.rdb']"
11+
}
12+
}
13+
],
14+
"warnings": []
15+
}

‎fixtures/conformance/error-parameter-ref-unresolved/input/meta.demo.json‎

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
{
2+
"metadata.root": {
3+
"package": "demo",
4+
"children": [
5+
{
6+
"object.entity": {
7+
"name": "BadProc",
8+
"children": [
9+
{
10+
"source.rdb": {
11+
"@kind": "storedProc",
12+
"@proc": "fn_x",
13+
"@parameterRef": "NonexistentArgs"
14+
}
15+
},
16+
{ "field.long": { "name": "id" } },
17+
{ "identity.primary": { "@fields": "id" } }
18+
]
19+
}
20+
}
21+
]
22+
}
23+
}

‎fixtures/conformance/parameter-ref-no-args/expected.json‎

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
{
2+
"metadata.root": {
3+
"package": "demo",
4+
"children": [
5+
{
6+
"object.entity": {
7+
"name": "Ping",
8+
"children": [
9+
{
10+
"source.rdb": {
11+
"@kind": "storedProc",
12+
"@proc": "fn_ping"
13+
}
14+
},
15+
{
16+
"field.long": {
17+
"name": "id"
18+
}
19+
},
20+
{
21+
"identity.primary": {
22+
"@fields": [
23+
"id"
24+
]
25+
}
26+
}
27+
]
28+
}
29+
}
30+
]
31+
}
32+
}

0 commit comments

Comments
 (0)